-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Fix KVS corner case #23641
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jepenven-silabs:silabs_fix_kvs_key_not_found
Nov 16, 2022
Merged
[Silabs] Fix KVS corner case #23641
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jepenven-silabs:silabs_fix_kvs_key_not_found
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix return code for KVS
jmartinez-silabs
approved these changes
Nov 16, 2022
PR #23641: Size comparison from bbf3111 to 7f122dc Increases (9 builds for cc13x2_26x2, efr32, psoc6, telink)
Decreases (7 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 16, 2022
bzbarsky-apple
approved these changes
Nov 16, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Fix return code for KVS
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Fix return code for KVS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A corner case is possible when the Key is written in the nvm3 but not the value (e.g. power cycle in between the two operation). When This happen, the error code returned is
CHIP_DEVICE_ERROR_CONFIG_NOT_FOUND
instead ofCHIP_ERROR_PERSISTED_STORAGE_VALUE_NOT_FOUND
Fix :
Addressed this.
Also Assert on
Server::Init()
failure as it should never happen.