Improve logic for deciding whether to re-establish CASE in ReadClient. #23627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could end up in a situation where we had a defunct session but did not have the "try to re-establish CASE" flag set. In that case we would keep trying resubscribe attempts, which would keep failing because we could not actually create an exchange on our session, and we would never recover from that.
The fix is that we try to re-establish CASE (assuming the IM engine
has a CASE Session manager) if we don't have an active session.
Also fixes an incorrect error ("no memory") being reported if we in
fact try to subscribe when our session is not active.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
pullapprove
bot
requested review from
kghost,
lazarkov,
LuDuda,
msandstedt,
mspang,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #23627: Size comparison from 700ee0e to ee28e16 Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
msandstedt
reviewed
Nov 16, 2022
msandstedt
reviewed
Nov 16, 2022
msandstedt
reviewed
Nov 16, 2022
pullapprove
bot
requested review from
mlepage-google
and removed request for
kghost
msandstedt
approved these changes
Nov 16, 2022
yunhanw-google
approved these changes
Nov 16, 2022
msandstedt
approved these changes
Nov 17, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
project-chip#23627) * Improve logic for deciding whether to re-establish CASE in ReadClient. We could end up in a situation where we had a defunct session but did not have the "try to re-establish CASE" flag set. In that case we would keep trying resubscribe attempts, which would keep failing because we could not actually create an exchange on our session, and we would never recover from that. The fix is that we try to re-establish CASE (assuming the IM engine has a CASE Session manager) if we don't have an active session. Also fixes an incorrect error ("no memory") being reported if we in fact try to subscribe when our session is not active. * Address review comments.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
project-chip#23627) * Improve logic for deciding whether to re-establish CASE in ReadClient. We could end up in a situation where we had a defunct session but did not have the "try to re-establish CASE" flag set. In that case we would keep trying resubscribe attempts, which would keep failing because we could not actually create an exchange on our session, and we would never recover from that. The fix is that we try to re-establish CASE (assuming the IM engine has a CASE Session manager) if we don't have an active session. Also fixes an incorrect error ("no memory") being reported if we in fact try to subscribe when our session is not active. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could end up in a situation where we had a defunct session but did not have the "try to re-establish CASE" flag set. In that case we would keep trying resubscribe attempts, which would keep failing because we could not actually create an exchange on our session, and we would never recover from that.
The fix is that we try to re-establish CASE (assuming the IM engine has a CASE Session manager) if we don't have an active session.
Also fixes an incorrect error ("no memory") being reported if we in fact try to subscribe when our session is not active.