Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: SetPairingState open CommissioningWindow #23622

Merged
merged 1 commit into from
Nov 18, 2022
Merged

RPC: SetPairingState open CommissioningWindow #23622

merged 1 commit into from
Nov 18, 2022

Conversation

rgoliver
Copy link

Problem:
Currently the RPC command SetPairingState only enables/disables Ble Advertising, it should also open a commissioning window.

Change:
If the commissioning window isn't already open, open a basic one when SetPairingState is true. Similarly close the commissioning window if SetPairingState is false.

Test:
Used RPC to toggle pairing off and back on and than successfully completed full commissioning with an m5.

@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

PR #23622: Size comparison from 700ee0e to 04f9362

Increases (10 builds for bl602, bl702, efr32, esp32, linux, mbed, psoc6, telink)
platform target config section 700ee0e 04f9362 change % change
bl602 lighting-app bl602+rpc (read/write) 1421074 1421466 392 0.0
.text 1090680 1090912 232 0.0
bl702 lighting-app bl702+rpc (read/write) 1283267 1283667 400 0.0
.debug_abbrev 1667931 1667947 16 0.0
.debug_info 43430527 43431155 628 0.0
.debug_line 5667078 5667791 713 0.0
.debug_loc 3561346 3561466 120 0.0
.debug_ranges 383296 383392 96 0.0
.rodata 130120 130280 160 0.1
.text 1029212 1029448 236 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974172 974452 280 0.0
.text 819724 820004 280 0.0
esp32 all-clusters-app c3devkit (read only) 1224288 1224290 2 0.0
.flash.text 1224288 1224290 2 0.0
linux lighting-app debug+rpc (read only) 2641089 2641393 304 0.0
.rodata 227552 227712 160 0.1
.text 2237122 2237266 144 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452336 2452552 216 0.0
.text 1414980 1415196 216 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26760522 26760523 1 0.0
light cy8ckit_062s2_43012 .debug_info 22225722 22225724 2 0.0
lock cy8ckit_062s2_43012 .debug_info 22459347 22459348 1 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790692 790700 8 0.0
text 554148 554150 2 0.0
Decreases (7 builds for bl602, bl702, cyw30739, esp32, telink)
platform target config section 700ee0e 04f9362 change % change
bl602 lighting-app bl602 (read/write) 1375258 1375250 -8 -0.0
.text 1059186 1059184 -2 -0.0
bl702 lighting-app bl702+rpc .strtab 626746 626576 -170 -0.0
.symtab 189920 189904 -16 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 591338 591330 -8 -0.0
.app_xip_area 462252 462244 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1788614 1788606 -8 -0.0
.flash.rodata 258184 258176 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937352 937344 -8 -0.0
text 648702 648700 -2 -0.0
lighting-app tlsr9518adk80d text 624114 624112 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805192 805184 -8 -0.0
text 565530 565528 -2 -0.0
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 700ee0e 04f9362 change % change
bl602 lighting-app bl602 (read/write) 1375258 1375250 -8 -0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059186 1059184 -2 -0.0
bl602+rpc (read/write) 1421074 1421466 392 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1090680 1090912 232 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195127 1195127 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1523919 1523919 0 0.0
.debug_aranges 132304 132304 0 0.0
.debug_frame 485212 485212 0 0.0
.debug_info 39161305 39161305 0 0.0
.debug_line 5271709 5271709 0 0.0
.debug_loc 3367110 3367110 0 0.0
.debug_ranges 360272 360272 0 0.0
.debug_str 3462160 3462160 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566531 566531 0 0.0
.symtab 171808 171808 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955514 955514 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283267 1283667 400 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1667931 1667947 16 0.0
.debug_aranges 140368 140368 0 0.0
.debug_frame 512416 512416 0 0.0
.debug_info 43430527 43431155 628 0.0
.debug_line 5667078 5667791 713 0.0
.debug_loc 3561346 3561466 120 0.0
.debug_ranges 383296 383392 96 0.0
.debug_str 3859469 3859469 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130120 130280 160 0.1
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 626746 626576 -170 -0.0
.symtab 189920 189904 -16 -0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029212 1029448 236 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678163 678163 0 0.0
(read/write) 173372 173372 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588000 588000 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642459 642459 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563152 563152 0 0.0
lock-ftd LP_CC2652R7 (read only) 676295 676295 0 0.0
(read/write) 172808 172808 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598544 598544 0 0.0
lock-mtd LP_CC2652R7 (read only) 660819 660819 0 0.0
(read/write) 183540 183540 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103307 103307 0 0.0
.text 557032 557032 0 0.0
pump-app LP_CC2652R7 (read only) 688743 688743 0 0.0
(read/write) 161096 161096 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90759 90759 0 0.0
.text 597500 597500 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673027 673027 0 0.0
(read/write) 176908 176908 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86307 86307 0 0.0
.text 586240 586240 0 0.0
shell LP_CC2652R7 (read only) 669382 669382 0 0.0
(read/write) 184472 184472 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582468 582468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587230 587230 0 0.0
.app_xip_area 463440 463440 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591338 591330 -8 -0.0
.app_xip_area 462252 462244 -8 -0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543714 543714 0 0.0
.app_xip_area 425444 425444 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974172 974452 280 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 819724 820004 280 0.0
BRD4161A+rs911x (read/write) 1034744 1034744 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 845972 845972 0 0.0
BRD4187C (read/write) 1146576 1146576 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 980808 980808 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160144 1160144 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 999836 999836 0 0.0
window-app BRD4187C (read/write) 1139812 1139812 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 972604 972604 0 0.0
esp32 all-clusters-app c3devkit (read only) 1224288 1224290 2 0.0
(read/write) 1788614 1788606 -8 -0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258184 258176 -8 -0.0
.flash.text 1224288 1224290 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234187 1234187 0 0.0
(read/write) 564412 564412 0 0.0
.dram0.bss 82320 82320 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315128 315128 0 0.0
.flash.text 1228803 1228803 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661796 661796 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563468 563468 0 0.0
light k32w0+release (read/write) 671800 671800 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592100 592100 0 0.0
lock k32w0+release (read/write) 633356 633356 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 552876 552876 0 0.0
linux all-clusters-app debug (read only) 3085417 3085417 0 0.0
(read/write) 158312 158312 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 86984 86984 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 280939 280939 0 0.0
.text 2620274 2620274 0 0.0
all-clusters-minimal-app debug (read only) 2911113 2911113 0 0.0
(read/write) 149712 149712 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79352 79352 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280427 280427 0 0.0
.text 2449522 2449522 0 0.0
bridge-app debug+rpc (read only) 2410065 2410065 0 0.0
(read/write) 129448 129448 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68616 68616 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210688 210688 0 0.0
.text 2032306 2032306 0 0.0
chip-tool debug (read only) 11079241 11079241 0 0.0
(read/write) 658304 658304 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623040 623040 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 591837 591837 0 0.0
.text 8963988 8963988 0 0.0
chip-tool-ipv6only arm64 (read only) 10433596 10433596 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650672 650672 0 0.0
.dynamic 560 560 0 0.0
.got 13912 13912 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8260020 8260020 0 0.0
lighting-app debug+rpc (read only) 2641089 2641393 304 0.0
(read/write) 132296 132296 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73832 73832 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227552 227712 160 0.1
.text 2237122 2237266 144 0.0
lock-app debug (read only) 2600329 2600329 0 0.0
(read/write) 127216 127216 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70680 70680 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 243848 243848 0 0.0
.text 2185058 2185058 0 0.0
ota-provider-app debug (read only) 2396497 2396497 0 0.0
(read/write) 120744 120744 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64600 64600 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216328 216328 0 0.0
.text 2011906 2011906 0 0.0
ota-requestor-app debug (read only) 2561809 2561809 0 0.0
(read/write) 129088 129088 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 69960 69960 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223408 223408 0 0.0
.text 2161042 2161042 0 0.0
shell debug (read only) 2621521 2621521 0 0.0
(read/write) 142808 142808 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77880 77880 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239250 239250 0 0.0
.text 2223042 2223042 0 0.0
thermostat-no-ble arm64 (read only) 2392812 2392812 0 0.0
(read/write) 143489 143489 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77096 77096 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144788 144788 0 0.0
.text 2004560 2004560 0 0.0
tv-app debug (read only) 3254881 3254881 0 0.0
(read/write) 261832 261832 0 0.0
.bss 170648 170648 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80224 80224 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268216 268216 0 0.0
.text 2792962 2792962 0 0.0
tv-casting-app debug (read only) 5580961 5580961 0 0.0
(read/write) 161720 161720 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101056 101056 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 355001 355001 0 0.0
.text 4950578 4950578 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452336 2452552 216 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1414980 1415196 216 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187855 1187855 0 0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 816982 816982 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167283 1167283 0 0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805532 805532 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746244 1746244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235716 1235716 0 0.0
.debug_aranges 110704 110704 0 0.0
.debug_frame 371284 371284 0 0.0
.debug_info 27023893 27023893 0 0.0
.debug_line 3685941 3685941 0 0.0
.debug_loc 3603774 3603774 0 0.0
.debug_ranges 339544 339544 0 0.0
.debug_str 3431051 3431051 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570257 570257 0 0.0
.symtab 421440 421440 0 0.0
.text 1546480 1546480 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1688780 1688780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227559 1227559 0 0.0
.debug_aranges 110176 110176 0 0.0
.debug_frame 374364 374364 0 0.0
.debug_info 26760522 26760523 1 0.0
.debug_line 3706925 3706925 0 0.0
.debug_loc 3591380 3591380 0 0.0
.debug_ranges 338160 338160 0 0.0
.debug_str 3420071 3420071 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534346 534346 0 0.0
.symtab 407872 407872 0 0.0
.text 1489752 1489752 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1606956 1606956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062020 1062020 0 0.0
.debug_aranges 102376 102376 0 0.0
.debug_frame 344676 344676 0 0.0
.debug_info 22225722 22225724 2 0.0
.debug_line 3276050 3276050 0 0.0
.debug_loc 3288865 3288865 0 0.0
.debug_ranges 303440 303440 0 0.0
.debug_str 3225606 3225606 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470671 470671 0 0.0
.symtab 376240 376240 0 0.0
.text 1416112 1416112 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640964 1640964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1063995 1063995 0 0.0
.debug_aranges 102776 102776 0 0.0
.debug_frame 346552 346552 0 0.0
.debug_info 22459347 22459348 1 0.0
.debug_line 3273170 3273170 0 0.0
.debug_loc 3316718 3316718 0 0.0
.debug_ranges 305400 305400 0 0.0
.debug_str 3244977 3244977 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473074 473074 0 0.0
.symtab 377936 377936 0 0.0
.text 1445128 1445128 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149312 1149312 0 0.0
.bss 109860 109860 0 0.0
.data 848 848 0 0.0
.text 596412 596412 0 0.0
lock-app qpg6105+debug (read/write) 1115060 1115060 0 0.0
.bss 106332 106332 0 0.0
.data 836 836 0 0.0
.text 562156 562156 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937352 937344 -8 -0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 648702 648700 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875344 875344 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 612688 612688 0 0.0
light-switch-app tlsr9518adk80d (read/write) 790692 790700 8 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554148 554150 2 0.0
lighting-app tlsr9518adk80d (read/write) 874924 874924 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624114 624112 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805192 805184 -8 -0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565530 565528 -2 -0.0

RPC: SetPairingState open CommissioningWindow
ad73902 
If the commissioning window isn't already open open a basic one
when SetPairingState is true. Similarily close the commissioining
window if SetPairingState is false.
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

PR #23622: Size comparison from bdfc185 to ad73902

Increases (7 builds for cc13x2_26x2, efr32, esp32, linux, mbed, nrfconnect)
platform target config section bdfc185 ad73902 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 689047 689055 8 0.0
.text 597764 597772 8 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974580 974708 128 0.0
.text 820132 820260 128 0.0
esp32 all-clusters-app c3devkit (read only) 1213514 1213516 2 0.0
.flash.text 1213514 1213516 2 0.0
m5stack (read/write) 562540 562548 8 0.0
.flash.rodata 313520 313528 8 0.0
linux lighting-app debug+rpc .rodata 227872 227936 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452672 2452736 64 0.0
.text 1415316 1415380 64 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167659 1167675 16 0.0
text 805878 805882 4 0.0
Decreases (8 builds for cc13x2_26x2, linux, psoc6, telink)
platform target config section bdfc185 ad73902 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 160792 160784 -8 -0.0
linux lighting-app debug+rpc (read only) 2633297 2633153 -144 -0.0
.text 2228722 2228514 -208 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27027690 27027689 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26764320 26764319 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22463155 22463154 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 613076 613072 -4 -0.0
light-switch-app tlsr9518adk80d text 554538 554536 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 875380 875372 -8 -0.0
text 624502 624500 -2 -0.0
Full report (47 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section bdfc185 ad73902 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678467 678467 0 0.0
(read/write) 173068 173068 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588304 588304 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642763 642763 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563456 563456 0 0.0
lock-ftd LP_CC2652R7 (read only) 676519 676519 0 0.0
(read/write) 172584 172584 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598768 598768 0 0.0
lock-mtd LP_CC2652R7 (read only) 661203 661203 0 0.0
(read/write) 183156 183156 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103355 103355 0 0.0
.text 557368 557368 0 0.0
pump-app LP_CC2652R7 (read only) 689047 689055 8 0.0
(read/write) 160792 160784 -8 -0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90799 90799 0 0.0
.text 597764 597772 8 0.0
pump-controller-app LP_CC2652R7 (read only) 673331 673331 0 0.0
(read/write) 176604 176604 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86347 86347 0 0.0
.text 586504 586504 0 0.0
shell LP_CC2652R7 (read only) 669686 669686 0 0.0
(read/write) 184168 184168 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582772 582772 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587446 587446 0 0.0
.app_xip_area 463656 463656 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591554 591554 0 0.0
.app_xip_area 462468 462468 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544010 544010 0 0.0
.app_xip_area 425740 425740 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974580 974708 128 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 820132 820260 128 0.0
BRD4161A+rs911x (read/write) 1035368 1035368 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 846596 846596 0 0.0
BRD4187C (read/write) 1147176 1147176 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 981408 981408 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160560 1160560 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1000252 1000252 0 0.0
window-app BRD4187C (read/write) 1140396 1140396 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 973188 973188 0 0.0
esp32 all-clusters-app c3devkit (read only) 1213514 1213516 2 0.0
(read/write) 1786582 1786582 0 0.0
.dram0.bss 76680 76680 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256408 256408 0 0.0
.flash.text 1213514 1213516 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1224391 1224391 0 0.0
(read/write) 562540 562548 8 0.0
.dram0.bss 82056 82056 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313520 313528 8 0.0
.flash.text 1219007 1219007 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662100 662100 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563772 563772 0 0.0
light k32w0+release (read/write) 672192 672192 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592492 592492 0 0.0
lock k32w0+release (read/write) 633660 633660 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553180 553180 0 0.0
linux all-clusters-app debug (read only) 3077625 3077625 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281323 281323 0 0.0
.text 2611810 2611810 0 0.0
all-clusters-minimal-app debug (read only) 2903321 2903321 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280811 280811 0 0.0
.text 2441058 2441058 0 0.0
bridge-app debug+rpc (read only) 2402241 2402241 0 0.0
(read/write) 129608 129608 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210976 210976 0 0.0
.text 2023906 2023906 0 0.0
chip-tool debug (read only) 11071265 11071265 0 0.0
(read/write) 658464 658464 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623200 623200 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 592165 592165 0 0.0
.text 8955396 8955396 0 0.0
chip-tool-ipv6only arm64 (read only) 10424780 10424780 0 0.0
(read/write) 706529 706529 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650832 650832 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518428 518428 0 0.0
.text 8250564 8250564 0 0.0
lighting-app debug+rpc (read only) 2633297 2633153 -144 -0.0
(read/write) 132456 132456 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73992 73992 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227872 227936 64 0.0
.text 2228722 2228514 -208 -0.0
lock-app debug (read only) 2592521 2592521 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244168 244168 0 0.0
.text 2176642 2176642 0 0.0
ota-provider-app debug (read only) 2388689 2388689 0 0.0
(read/write) 120904 120904 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216648 216648 0 0.0
.text 2003490 2003490 0 0.0
ota-requestor-app debug (read only) 2553953 2553953 0 0.0
(read/write) 129248 129248 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223728 223728 0 0.0
.text 2152578 2152578 0 0.0
shell debug (read only) 2614817 2614817 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239538 239538 0 0.0
.text 2215762 2215762 0 0.0
thermostat-no-ble arm64 (read only) 2384124 2384124 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144996 144996 0 0.0
.text 1995232 1995232 0 0.0
tv-app debug (read only) 3246977 3246977 0 0.0
(read/write) 261992 261992 0 0.0
.bss 170648 170648 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268568 268568 0 0.0
.text 2784418 2784418 0 0.0
tv-casting-app debug (read only) 5572961 5572961 0 0.0
(read/write) 161880 161880 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101216 101216 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 355353 355353 0 0.0
.text 4941938 4941938 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452672 2452736 64 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1415316 1415380 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188243 1188243 0 0.0
bss 145285 145285 0 0.0
rodata 144552 144552 0 0.0
text 817332 817332 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167659 1167675 16 0.0
bss 144512 144512 0 0.0
rodata 136344 136344 0 0.0
text 805878 805882 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746868 1746868 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235876 1235876 0 0.0
.debug_aranges 110728 110728 0 0.0
.debug_frame 371396 371396 0 0.0
.debug_info 27027690 27027689 -1 -0.0
.debug_line 3687746 3687746 0 0.0
.debug_loc 3606504 3606504 0 0.0
.debug_ranges 340032 340032 0 0.0
.debug_str 3432511 3432511 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570636 570636 0 0.0
.symtab 421600 421600 0 0.0
.text 0 0 0 0.0
1547104 1547104 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1689404 1689404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227719 1227719 0 0.0
.debug_aranges 110200 110200 0 0.0
.debug_frame 374476 374476 0 0.0
.debug_info 26764320 26764319 -1 -0.0
.debug_line 3708730 3708730 0 0.0
.debug_loc 3594110 3594110 0 0.0
.debug_ranges 338648 338648 0 0.0
.debug_str 3421531 3421531 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534725 534725 0 0.0
.symtab 408032 408032 0 0.0
.text 1490376 1490376 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1607564 1607564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062180 1062180 0 0.0
.debug_aranges 102400 102400 0 0.0
.debug_frame 344788 344788 0 0.0
.debug_info 22229530 22229530 0 0.0
.debug_line 3277857 3277857 0 0.0
.debug_loc 3291595 3291595 0 0.0
.debug_ranges 303928 303928 0 0.0
.debug_str 3227066 3227066 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471050 471050 0 0.0
.symtab 376400 376400 0 0.0
.text 1416720 1416720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1641588 1641588 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064155 1064155 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346664 346664 0 0.0
.debug_info 22463155 22463154 -1 -0.0
.debug_line 3274977 3274977 0 0.0
.debug_loc 3319448 3319448 0 0.0
.debug_ranges 305888 305888 0 0.0
.debug_str 3246423 3246423 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473453 473453 0 0.0
.symtab 378096 378096 0 0.0
.text 1445752 1445752 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151104 1151104 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 598204 598204 0 0.0
lock-app qpg6105+debug (read/write) 1116880 1116880 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 563976 563976 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937800 937800 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 649088 649088 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875792 875792 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 613076 613072 -4 -0.0
light-switch-app tlsr9518adk80d (read/write) 791148 791148 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554538 554536 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 875380 875372 -8 -0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624502 624500 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805640 805640 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565916 565916 0 0.0

@rgoliver rgoliver merged commit 287c1b5 into project-chip:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgoliver @andy31415 @bzbarsky-apple