-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implementation of OnChipScanComplete and OnScanComplete #23612
Conversation
PR #23612: Size comparison from 6519b91 to 5218d5a Increases (13 builds for linux, telink)
Decreases (4 builds for esp32, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the summary: the text asked you to provide details and delete the instruction text. You did not delete the instruction text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlatusek - Testing via CI is not possible: CI has no BLE capabilities. This needs at least some manual check.
5218d5a
to
1e8a744
Compare
PR #23612: Size comparison from 733afaa to 1e8a744 Increases (17 builds for bl602, cc13x2_26x2, efr32, esp32, linux, telink)
Decreases (5 builds for bl602, bl702, psoc6, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
131786d
to
844c61b
Compare
PR #23612: Size comparison from 87994ad to 844c61b Increases (6 builds for bl702, efr32, esp32, linux, psoc6, telink)
Decreases (5 builds for bl702, esp32, k32w, nrfconnect, telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Create a separate error handler for scan errors
Create a separate function to handle scan errors.
844c61b
to
58cd948
Compare
PR #23612: Size comparison from 4a8f8eb to 1856dc2 Increases (19 builds for cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23612: Size comparison from 04c20f6 to 325e166 Increases (4 builds for bl602, bl702, cc13x2_26x2, linux)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23612: Size comparison from 5c8ae45 to 0cf9022 Increases (6 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for bl602, bl702, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Problem
When the chip-tool is shutting down because of timeout from StartWaiting then mBleLayer->mBleTransport is firstly set to nullptr and OnBleConnectionError is called on this pointer.
Fix
I've changed the implementation of OnScanComplete to do not call
OnConnectionError
it seems that this isn't the right place to do it. I've createdOnScanError
, which is called when the error occurs during scanning. Now it is called from TimerExpiredCallback which is the callback for a timeout for scan task. For kConnectTimeoutOnConnectionError
is called here if an error occurred.Testing
Manually tested on the Linux platform on one device I've run:
and on the other Linux device I've run: