-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spake2p: generate verifier sets with specified PIN codes in a file #23606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wqx6
changed the title
spake2: generate verifier sets with specified PIN codes in a file
spake2p: generate verifier sets with specified PIN codes in a file
Nov 15, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
November 15, 2022 11:52
pullapprove
bot
requested review from
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 15, 2022 11:52
PR #23606: Size comparison from 9a41c9c to eb794d7 Increases (3 builds for cc13x2_26x2, esp32, psoc6)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
emargolis
suggested changes
Nov 15, 2022
emargolis
reviewed
Nov 15, 2022
emargolis
reviewed
Nov 15, 2022
emargolis
approved these changes
Nov 16, 2022
emargolis
reviewed
Nov 16, 2022
wqx6
force-pushed
the
spake2p/pin-code-file
branch
from
November 16, 2022 03:22
302903d
to
6bd0305
Compare
PR #23606: Size comparison from 700ee0e to 6bd0305 Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (1 build for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Nov 16, 2022
wqx6
force-pushed
the
spake2p/pin-code-file
branch
2 times, most recently
from
November 17, 2022 03:44
4e0b941
to
e710a9e
Compare
PR #23606: Size comparison from 751d0dd to e710a9e Increases (2 builds for bl602, nrfconnect)
Decreases (6 builds for cyw30739, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23606: Size comparison from 6978de7 to bd573cd Increases (4 builds for cc13x2_26x2, esp32, psoc6)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, efr32, psoc6, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
wqx6
force-pushed
the
spake2p/pin-code-file
branch
from
November 18, 2022 06:33
bd573cd
to
54e7d4f
Compare
wqx6
force-pushed
the
spake2p/pin-code-file
branch
from
November 18, 2022 06:34
54e7d4f
to
d218345
Compare
bzbarsky-apple
approved these changes
Nov 18, 2022
PR #23606: Size comparison from 95d337c to d218345 Increases (9 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Currently we cannot generate spake2+ verifier sets with specified PIN codes. Only the first set will use the specified PIN code value. And others will be randomly generated.
Changes
Add an option
--pin-code-file
forspake2p
tool. The PIN codes in the file will be used to generate spake2+ verifier.Test
Tested with following command: