Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop passing passcode by mutable reference to Spake2pVerifier::Generate. #23571

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Stop passing passcode by mutable reference to Spake2pVerifier::Generate. #23571

merged 1 commit into from
Nov 11, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

The generation bits never modify the passcode.

Fixes #23511

@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

PR #23571: Size comparison from 599ad3b to 4fe6b21

Increases (8 builds for bl702, cc13x2_26x2, psoc6)
platform target config section 599ad3b 4fe6b21 change % change
bl702 lighting-app bl702 .debug_loc 3367060 3367110 50 0.0
bl702+rpc .debug_loc 3561296 3561346 50 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 172800 172808 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 176900 176908 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_loc 3603685 3603743 58 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_loc 3591322 3591380 58 0.0
light cy8ckit_062s2_43012 .debug_loc 3288807 3288865 58 0.0
lock cy8ckit_062s2_43012 .debug_loc 3316660 3316718 58 0.0
Decreases (17 builds for bl602, bl702, cc13x2_26x2, k32w, nrfconnect, psoc6, telink)
platform target config section 599ad3b 4fe6b21 change % change
bl602 lighting-app bl602 .text 1059188 1059186 -2 -0.0
bl702 lighting-app bl702 .debug_info 39161319 39161306 -13 -0.0
.debug_line 5271721 5271709 -12 -0.0
.debug_str 3462154 3462152 -2 -0.0
.strtab 566532 566531 -1 -0.0
.text 955518 955516 -2 -0.0
bl702+rpc .debug_info 43430541 43430528 -13 -0.0
.debug_line 5667090 5667078 -12 -0.0
.debug_str 3859443 3859441 -2 -0.0
.strtab 626747 626746 -1 -0.0
.text 1029216 1029214 -2 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 676303 676295 -8 -0.0
.text 598552 598544 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 673035 673027 -8 -0.0
.text 586248 586240 -8 -0.0
k32w light k32w0+release (read/write) 671816 671800 -16 -0.0
.text 592116 592100 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187871 1187855 -16 -0.0
text 816986 816982 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 805536 805532 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27023906 27023894 -12 -0.0
.debug_line 3685946 3685941 -5 -0.0
.debug_str 3431045 3431043 -2 -0.0
.strtab 570258 570257 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1688796 1688780 -16 -0.0
.debug_info 26760536 26760523 -13 -0.0
.debug_line 3706930 3706925 -5 -0.0
.debug_str 3420065 3420063 -2 -0.0
.strtab 534347 534346 -1 -0.0
.text 1489768 1489752 -16 -0.0
light cy8ckit_062s2_43012 .debug_info 22225736 22225722 -14 -0.0
.debug_line 3276055 3276050 -5 -0.0
.debug_str 3225600 3225598 -2 -0.0
.strtab 470672 470671 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 2245936 22459349 -12 -0.0
.debug_line 3273175 3273170 -5 -0.0
.debug_str 3244971 3244969 -2 -0.0
.strtab 473075 473074 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 648704 648702 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 612690 612688 -2 -0.0
light-switch-app tlsr9518adk80d text 554154 554150 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 874932 874924 -8 -0.0
text 624118 624112 -6 -0.0
ota-requestor-app tlsr9518adk80d text 565532 565530 -2 -0.0
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 599ad3b 4fe6b21 change % change
bl602 lighting-app bl602 (read/write) 1375258 1375258 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059188 1059186 -2 -0.0
bl602+rpc (read/write) 1421082 1421082 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1090682 1090682 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195127 1195127 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1523919 1523919 0 0.0
.debug_aranges 132304 132304 0 0.0
.debug_frame 485212 485212 0 0.0
.debug_info 39161319 39161306 -13 -0.0
.debug_line 5271721 5271709 -12 -0.0
.debug_loc 3367060 3367110 50 0.0
.debug_ranges 360272 360272 0 0.0
.debug_str 3462154 3462152 -2 -0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566532 566531 -1 -0.0
.symtab 171808 171808 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955518 955516 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283267 1283267 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1667931 1667931 0 0.0
.debug_aranges 140368 140368 0 0.0
.debug_frame 512416 512416 0 0.0
.debug_info 43430541 43430528 -13 -0.0
.debug_line 5667090 5667078 -12 -0.0
.debug_loc 3561296 3561346 50 0.0
.debug_ranges 383296 383296 0 0.0
.debug_str 3859443 3859441 -2 -0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130120 130120 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 626747 626746 -1 -0.0
.symtab 189920 189920 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029216 1029214 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678163 678163 0 0.0
(read/write) 173372 173372 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588000 588000 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642459 642459 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563152 563152 0 0.0
lock-ftd LP_CC2652R7 (read only) 676303 676295 -8 -0.0
(read/write) 172800 172808 8 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598552 598544 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 660819 660819 0 0.0
(read/write) 183540 183540 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103307 103307 0 0.0
.text 557032 557032 0 0.0
pump-app LP_CC2652R7 (read only) 688743 688743 0 0.0
(read/write) 161096 161096 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90759 90759 0 0.0
.text 597500 597500 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673035 673027 -8 -0.0
(read/write) 176900 176908 8 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86307 86307 0 0.0
.text 586248 586240 -8 -0.0
shell LP_CC2652R7 (read only) 669382 669382 0 0.0
(read/write) 184472 184472 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582468 582468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587230 587230 0 0.0
.app_xip_area 463440 463440 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591338 591338 0 0.0
.app_xip_area 462252 462252 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543714 543714 0 0.0
.app_xip_area 425444 425444 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read/write) 661796 661796 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563468 563468 0 0.0
light k32w0+release (read/write) 671816 671800 -16 -0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592116 592100 -16 -0.0
lock k32w0+release (read/write) 633356 633356 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 552876 552876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10433596 10433596 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650672 650672 0 0.0
.dynamic 560 560 0 0.0
.got 13912 13912 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8260020 8260020 0 0.0
thermostat-no-ble arm64 (read only) 2392092 2392092 0 0.0
(read/write) 143777 143777 0 0.0
.bss 55393 55393 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77328 77328 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144724 144724 0 0.0
.text 2004000 2004000 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452336 2452336 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1414980 1414980 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187871 1187855 -16 -0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 816986 816982 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167283 1167283 0 0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805536 805532 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841968 841968 0 0.0
(read/write) 1746244 1746244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235716 1235716 0 0.0
.debug_aranges 110704 110704 0 0.0
.debug_frame 371284 371284 0 0.0
.debug_info 27023906 27023894 -12 -0.0
.debug_line 3685946 3685941 -5 -0.0
.debug_loc 3603685 3603743 58 0.0
.debug_ranges 339544 339544 0 0.0
.debug_str 3431045 3431043 -2 -0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570258 570257 -1 -0.0
.symtab 421440 421440 0 0.0
.text 1546480 1546480 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842704 842704 0 0.0
(read/write) 1688796 1688780 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227559 1227559 0 0.0
.debug_aranges 110176 110176 0 0.0
.debug_frame 374364 374364 0 0.0
.debug_info 26760536 26760523 -13 -0.0
.debug_line 3706930 3706925 -5 -0.0
.debug_loc 3591322 3591380 58 0.0
.debug_ranges 338160 338160 0 0.0
.debug_str 3420065 3420063 -2 -0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534347 534346 -1 -0.0
.symtab 407872 407872 0 0.0
.text 1489768 1489752 -16 -0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850888 850888 0 0.0
(read/write) 1606956 1606956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062020 1062020 0 0.0
.debug_aranges 102376 102376 0 0.0
.debug_frame 344676 344676 0 0.0
.debug_info 22225736 22225722 -14 -0.0
.debug_line 3276055 3276050 -5 -0.0
.debug_loc 3288807 3288865 58 0.0
.debug_ranges 303440 303440 0 0.0
.debug_str 3225600 3225598 -2 -0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470672 470671 -1 -0.0
.symtab 376240 376240 0 0.0
.text 1416112 1416112 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845896 845896 0 0.0
(read/write) 1640964 1640964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1063995 1063995 0 0.0
.debug_aranges 102776 102776 0 0.0
.debug_frame 346552 346552 0 0.0
.debug_info 2245936 22459349 -12 -0.0
.debug_line 3273175 3273170 -5 -0.0
.debug_loc 3316660 3316718 58 0.0
.debug_ranges 305400 305400 0 0.0
.debug_str 3244971 3244969 -2 -0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473075 473074 -1 -0.0
.symtab 377936 377936 0 0.0
.text 1445128 1445128 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149312 1149312 0 0.0
.bss 109860 109860 0 0.0
.data 848 848 0 0.0
.text 596412 596412 0 0.0
lock-app qpg6105+debug (read/write) 1115060 1115060 0 0.0
.bss 106332 106332 0 0.0
.data 836 836 0 0.0
.text 562156 562156 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937352 937352 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 648704 648702 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875344 875344 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 612690 612688 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 790700 790700 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554154 554150 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 874932 874924 -8 -0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624118 624112 -6 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805192 805192 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565532 565530 -2 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the stop-taking-passcode-non-const-ref branch from 4fe6b21 to 9193e8e Compare November 10, 2022 14:02
@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

PR #23571: Size comparison from 599ad3b to 9193e8e

Increases (8 builds for bl702, cc13x2_26x2, psoc6)
platform target config section 599ad3b 9193e8e change % change
bl702 lighting-app bl702 .debug_loc 3367060 3367110 50 0.0
bl702+rpc .debug_loc 3561296 3561346 50 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 172800 172808 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 176900 176908 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_loc 3603685 3603743 58 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_loc 3591322 3591380 58 0.0
light cy8ckit_062s2_43012 .debug_loc 3288807 3288865 58 0.0
lock cy8ckit_062s2_43012 .debug_loc 3316660 3316718 58 0.0
Decreases (20 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, k32w, nrfconnect, psoc6, telink)
platform target config section 599ad3b 9193e8e change % change
bl602 lighting-app bl602 (read/write) 1375258 1375250 -8 -0.0
.text 1059188 1059184 -4 -0.0
bl602+rpc (read/write) 1421082 1421074 -8 -0.0
.text 1090682 1090680 -2 -0.0
bl702 lighting-app bl702 .debug_info 39161319 39161306 -13 -0.0
.debug_line 5271721 5271709 -12 -0.0
.debug_str 3462154 3462152 -2 -0.0
.strtab 566532 566531 -1 -0.0
.text 955518 955516 -2 -0.0
bl702+rpc .debug_info 43430541 43430528 -13 -0.0
.debug_line 5667090 5667078 -12 -0.0
.debug_str 3859443 3859441 -2 -0.0
.strtab 626747 626746 -1 -0.0
.text 1029216 1029214 -2 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 676303 676295 -8 -0.0
.text 598552 598544 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 673035 673027 -8 -0.0
.text 586248 586240 -8 -0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1034720 1034704 -16 -0.0
.text 845956 845940 -16 -0.0
esp32 all-clusters-app c3devkit (read/write) 1788614 1788606 -8 -0.0
.flash.rodata 258184 258176 -8 -0.0
m5stack (read only) 1234191 1234187 -4 -0.0
.flash.text 1228807 1228803 -4 -0.0
k32w light k32w0+release (read/write) 671816 671800 -16 -0.0
.text 592116 592100 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187871 1187855 -16 -0.0
text 816986 816978 -8 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 805536 805532 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27023906 27023892 -14 -0.0
.debug_line 3685946 3685941 -5 -0.0
.debug_str 3431045 3431043 -2 -0.0
.strtab 570258 570257 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1688796 1688780 -16 -0.0
.debug_info 26760536 26760524 -12 -0.0
.debug_line 3706930 3706925 -5 -0.0
.debug_str 3420065 3420063 -2 -0.0
.strtab 534347 534346 -1 -0.0
.text 1489768 1489752 -16 -0.0
light cy8ckit_062s2_43012 .debug_info 22225736 22225724 -12 -0.0
.debug_line 3276055 3276050 -5 -0.0
.debug_str 3225600 3225598 -2 -0.0
.strtab 470672 470671 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 2245936 22459347 -14 -0.0
.debug_line 3273175 3273170 -5 -0.0
.debug_str 3244971 3244969 -2 -0.0
.strtab 473075 473074 -1 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937352 937344 -8 -0.0
text 648704 648700 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d text 612690 612688 -2 -0.0
light-switch-app tlsr9518adk80d text 554154 554150 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 874932 874924 -8 -0.0
text 624118 624112 -6 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 599ad3b 9193e8e change % change
bl602 lighting-app bl602 (read/write) 1375258 1375250 -8 -0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059188 1059184 -4 -0.0
bl602+rpc (read/write) 1421082 1421074 -8 -0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1090682 1090680 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195127 1195127 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1523919 1523919 0 0.0
.debug_aranges 132304 132304 0 0.0
.debug_frame 485212 485212 0 0.0
.debug_info 39161319 39161306 -13 -0.0
.debug_line 5271721 5271709 -12 -0.0
.debug_loc 3367060 3367110 50 0.0
.debug_ranges 360272 360272 0 0.0
.debug_str 3462154 3462152 -2 -0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566532 566531 -1 -0.0
.symtab 171808 171808 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955518 955516 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283267 1283267 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1667931 1667931 0 0.0
.debug_aranges 140368 140368 0 0.0
.debug_frame 512416 512416 0 0.0
.debug_info 43430541 43430528 -13 -0.0
.debug_line 5667090 5667078 -12 -0.0
.debug_loc 3561296 3561346 50 0.0
.debug_ranges 383296 383296 0 0.0
.debug_str 3859443 3859441 -2 -0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130120 130120 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 626747 626746 -1 -0.0
.symtab 189920 189920 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029216 1029214 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678163 678163 0 0.0
(read/write) 173372 173372 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588000 588000 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642459 642459 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563152 563152 0 0.0
lock-ftd LP_CC2652R7 (read only) 676303 676295 -8 -0.0
(read/write) 172800 172808 8 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598552 598544 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 660819 660819 0 0.0
(read/write) 183540 183540 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103307 103307 0 0.0
.text 557032 557032 0 0.0
pump-app LP_CC2652R7 (read only) 688743 688743 0 0.0
(read/write) 161096 161096 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90759 90759 0 0.0
.text 597500 597500 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673035 673027 -8 -0.0
(read/write) 176900 176908 8 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86307 86307 0 0.0
.text 586248 586240 -8 -0.0
shell LP_CC2652R7 (read only) 669382 669382 0 0.0
(read/write) 184472 184472 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582468 582468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587230 587230 0 0.0
.app_xip_area 463440 463440 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591338 591338 0 0.0
.app_xip_area 462252 462252 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543714 543714 0 0.0
.app_xip_area 425444 425444 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974172 974172 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 819724 819724 0 0.0
BRD4161A+rs911x (read/write) 1034720 1034704 -16 -0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 845956 845940 -16 -0.0
BRD4187C (read/write) 1146552 1146552 0 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 980792 980792 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160120 1160120 0 0.0
.bss 158256 158256 0 0.0
.data 2020 2020 0 0.0
.text 999820 999820 0 0.0
window-app BRD4187C (read/write) 1139772 1139772 0 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 972572 972572 0 0.0
esp32 all-clusters-app c3devkit (read only) 1224292 1224292 0 0.0
(read/write) 1788614 1788606 -8 -0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258184 258176 -8 -0.0
.flash.text 1224292 1224292 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234191 1234187 -4 -0.0
(read/write) 564412 564412 0 0.0
.dram0.bss 82320 82320 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315128 315128 0 0.0
.flash.text 1228807 1228803 -4 -0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661796 661796 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563468 563468 0 0.0
light k32w0+release (read/write) 671816 671800 -16 -0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592116 592100 -16 -0.0
lock k32w0+release (read/write) 633356 633356 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 552876 552876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10433596 10433596 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650672 650672 0 0.0
.dynamic 560 560 0 0.0
.got 13912 13912 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8260020 8260020 0 0.0
thermostat-no-ble arm64 (read only) 2392092 2392092 0 0.0
(read/write) 143777 143777 0 0.0
.bss 55393 55393 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77328 77328 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144724 144724 0 0.0
.text 2004000 2004000 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452336 2452336 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1414980 1414980 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187871 1187855 -16 -0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 816986 816978 -8 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167283 1167283 0 0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805536 805532 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746244 1746244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235716 1235716 0 0.0
.debug_aranges 110704 110704 0 0.0
.debug_frame 371284 371284 0 0.0
.debug_info 27023906 27023892 -14 -0.0
.debug_line 3685946 3685941 -5 -0.0
.debug_loc 3603685 3603743 58 0.0
.debug_ranges 339544 339544 0 0.0
.debug_str 3431045 3431043 -2 -0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570258 570257 -1 -0.0
.symtab 421440 421440 0 0.0
.text 1546480 1546480 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1688796 1688780 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227559 1227559 0 0.0
.debug_aranges 110176 110176 0 0.0
.debug_frame 374364 374364 0 0.0
.debug_info 26760536 26760524 -12 -0.0
.debug_line 3706930 3706925 -5 -0.0
.debug_loc 3591322 3591380 58 0.0
.debug_ranges 338160 338160 0 0.0
.debug_str 3420065 3420063 -2 -0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534347 534346 -1 -0.0
.symtab 407872 407872 0 0.0
.text 1489768 1489752 -16 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1606956 1606956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062020 1062020 0 0.0
.debug_aranges 102376 102376 0 0.0
.debug_frame 344676 344676 0 0.0
.debug_info 22225736 22225724 -12 -0.0
.debug_line 3276055 3276050 -5 -0.0
.debug_loc 3288807 3288865 58 0.0
.debug_ranges 303440 303440 0 0.0
.debug_str 3225600 3225598 -2 -0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470672 470671 -1 -0.0
.symtab 376240 376240 0 0.0
.text 1416112 1416112 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640964 1640964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1063995 1063995 0 0.0
.debug_aranges 102776 102776 0 0.0
.debug_frame 346552 346552 0 0.0
.debug_info 2245936 22459347 -14 -0.0
.debug_line 3273175 3273170 -5 -0.0
.debug_loc 3316660 3316718 58 0.0
.debug_ranges 305400 305400 0 0.0
.debug_str 3244971 3244969 -2 -0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473075 473074 -1 -0.0
.symtab 377936 377936 0 0.0
.text 1445128 1445128 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149312 1149312 0 0.0
.bss 109860 109860 0 0.0
.data 848 848 0 0.0
.text 596412 596412 0 0.0
lock-app qpg6105+debug (read/write) 1115060 1115060 0 0.0
.bss 106332 106332 0 0.0
.data 836 836 0 0.0
.text 562156 562156 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937352 937344 -8 -0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 648704 648700 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875344 875344 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 612690 612688 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 790700 790700 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554154 554150 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 874932 874924 -8 -0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624118 624112 -6 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805192 805192 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565532 565532 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 008df4d into project-chip:master Nov 11, 2022
@bzbarsky-apple bzbarsky-apple deleted the stop-taking-passcode-non-const-ref branch November 11, 2022 05:32
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Stop passing passcode by mutable reference to Spake2pVerifier::Genera…
49d78f5 
…te. (project-chip#23571)

The generation bits never modify the passcode.

Fixes project-chip#23511
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Stop passing passcode by mutable reference to Spake2pVerifier::Genera…
9aff835 
…te. (project-chip#23571)

The generation bits never modify the passcode.

Fixes project-chip#23511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@emargolis emargolis emargolis approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
crypto darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spake2pVerifier::Generate should not take the passcode by non-const reference
3 participants
@bzbarsky-apple @emargolis @Damian-Nordic