-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert TSAN workaround #23542
Closed
Closed
Revert TSAN workaround #23542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit added "Workaround for TSAN false positive reports with glib". With properly compiled glib-2.0 libraries for TSAN check such workaround is no longer required. Also, it seems that this workaround causes some issues...
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
November 8, 2022 10:20
pullapprove
bot
requested review from
yufengwangca,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
November 8, 2022 10:20
PR #23542: Size comparison from be90d4d to 126b05e Increases (10 builds for bl602, bl702, qpg, telink)
Decreases (3 builds for linux, nrfconnect)
Full report (19 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #23542: Size comparison from be90d4d to 25c4dfc Increases (10 builds for bl702, esp32, linux, psoc6, qpg, telink)
Decreases (17 builds for bl602, bl702, cyw30739, linux, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Superseded by #23545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It seems that the TSAN workaround causes timeout when commissioning with BLE.
Changes
Testing
Tested manually with chip-tool (Linux) + lighting (Linux)
Also, tested by @s07641069