-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue of content app losing connection to the platform-app. #23536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
November 7, 2022 21:27
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 7, 2022 21:27
PR #23536: Size comparison from b278e34 to 72fbdd2 Increases (7 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (5 builds for psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Nov 7, 2022
...les/tv-app/android/App/content-app/src/main/java/com/example/contentapp/AttributeHolder.java
Show resolved
Hide resolved
andy31415
reviewed
Nov 14, 2022
...les/tv-app/android/App/content-app/src/main/java/com/example/contentapp/AttributeHolder.java
Show resolved
Hide resolved
pullapprove
bot
requested review from
mrjerryjohns and
turon
and removed request for
kghost and
erjiaqing
November 16, 2022 23:47
pullapprove
bot
requested review from
ksperling-apple and
lpbeliveau-silabs
and removed request for
isiu-apple and
wbschiller
December 22, 2022 15:30
amitnj
force-pushed
the
tv-app-issue-23535
branch
from
January 12, 2023 07:29
a4e069d
to
2377f31
Compare
PR #23536: Size comparison from dacb056 to 2377f31 Increases (6 builds for bl602, cyw30739, nrfconnect, telink)
Decreases (8 builds for bl702, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 12, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ect-chip#23536) * Fix issue of content app losing connection to the platform-app. * Restyled by google-java-format * Added comments to the attribute holder class. * Restyled by google-java-format * Fix styling Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23535
Fixed the handling of how the service binding is maintained in the client. Taken care of service disconnections correctly. Maintaining internal state of the client correctly.