-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More cluster define renames for consistency with spec cluster names #23487
Merged
Damian-Nordic
merged 6 commits into
project-chip:master
from
andy31415:more_renames_for_define_consistency
Nov 4, 2022
Merged
More cluster define renames for consistency with spec cluster names #23487
Damian-Nordic
merged 6 commits into
project-chip:master
from
andy31415:more_renames_for_define_consistency
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple and
jelderton
November 4, 2022 03:02
pullapprove
bot
requested review from
vivien-apple,
mspang,
wbschiller,
rgoliver,
woody-apple,
robszewczyk,
xylophone21,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon and
vijs
November 4, 2022 03:02
…NFIGURATION_CLUSTER (even though this does NOT seem to be a valid matter cluster ... name taken from zigbee
PR #23487: Size comparison from 42b4438 to 754830b Increases (11 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (3 builds for bl602, cyw30739, psoc6)
Full report (44 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 4, 2022
arkq
approved these changes
Nov 4, 2022
Damian-Nordic
approved these changes
Nov 4, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23487) * Rename PUMP_CONFIG_CONTROL to PUMP_CONFIGURATION_AND_CONTROL * Rename TEMP_MEASUREMENT_CLUSTER to TEMPERATURE_MEASUREMENT_CLUSTER * zap regen * Restyle * rename THERMOSTAT_UI_CONFIG_CLUSTER into THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER (even though this does NOT seem to be a valid matter cluster ... name taken from zigbee * zap regen
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23487) * Rename PUMP_CONFIG_CONTROL to PUMP_CONFIGURATION_AND_CONTROL * Rename TEMP_MEASUREMENT_CLUSTER to TEMPERATURE_MEASUREMENT_CLUSTER * zap regen * Restyle * rename THERMOSTAT_UI_CONFIG_CLUSTER into THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER (even though this does NOT seem to be a valid matter cluster ... name taken from zigbee * zap regen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames:
This is to make define names consistent with the cluster naming (which in turn should be consistent with the spec).
Also it seems to me that not all of these clusters are matter spec... but that is a problem to be solved separately.