Replace operator const char * from StorageKeyName with an explicit call
#23480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```shell
rg '\(DefaultStorageKeyAllocator::[a-zA-Z]*\([a-zA-Z0-9_,]*\)' | cut -f1
-d: | uniq | xargs sd
'(\\(DefaultStorageKeyAllocator::[a-zA-Z]*\\([a-zA-Z0-9_,]*\\))'
'${1}.KeyName()'
```
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
github-actions
bot
added
app
crypto
esp32
examples
lib
platform
support
transport
labels
tcarmelveilleux
approved these changes
Nov 3, 2022
|
PR #23480: Size comparison from c9fdd12 to 3103c6e Increases (26 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, mbed, psoc6, qpg, telink)
Decreases (11 builds for bl702, cc13x2_26x2, psoc6)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
|
|
PR #23480: Size comparison from c9fdd12 to aa36887 Increases (16 builds for bl702, cc13x2_26x2, esp32, linux, mbed, psoc6)
Decreases (30 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Nov 4, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…call (project-chip#23480) * Mass rename: ```shell rg '\(DefaultStorageKeyAllocator::[a-zA-Z]*\([a-zA-Z0-9_,]*\)' | cut -f1 -d: | uniq | xargs sd '(\\(DefaultStorageKeyAllocator::[a-zA-Z]*\\([a-zA-Z0-9_,]*\\))' '${1}.KeyName()' ``` * Added a lot more KeyName * Restyle * A few more changes to make things compile * More fixes * Restyle * One more missed usage of Keyname in tests
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…call (project-chip#23480) * Mass rename: ```shell rg '\(DefaultStorageKeyAllocator::[a-zA-Z]*\([a-zA-Z0-9_,]*\)' | cut -f1 -d: | uniq | xargs sd '(\\(DefaultStorageKeyAllocator::[a-zA-Z]*\\([a-zA-Z0-9_,]*\\))' '${1}.KeyName()' ``` * Added a lot more KeyName * Restyle * A few more changes to make things compile * More fixes * Restyle * One more missed usage of Keyname in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was based on feedback from Tennessee on #23422 - auto casting seems too much magic and maybe error prone.