-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDevice subscription should be non-fabric-filtered #23473
Merged
jtung-apple
merged 1 commit into
project-chip:master
from
jtung-apple:issue-23472-MTRDevice-make-non-fabric-filtered-subscription
Dec 1, 2022
Merged
[Darwin] MTRDevice subscription should be non-fabric-filtered #23473
jtung-apple
merged 1 commit into
project-chip:master
from
jtung-apple:issue-23472-MTRDevice-make-non-fabric-filtered-subscription
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
rgoliver and
robszewczyk
November 3, 2022 17:27
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 3, 2022 17:27
bzbarsky-apple
approved these changes
Nov 4, 2022
andy31415
approved these changes
Nov 4, 2022
jtung-apple
force-pushed
the
issue-23472-MTRDevice-make-non-fabric-filtered-subscription
branch
from
November 30, 2022 23:02
78ea795
to
545f739
Compare
pullapprove
bot
requested review from
lpbeliveau-silabs
and removed request for
wbschiller and
kpschoedel
November 30, 2022 23:03
Rebased to master |
PR #23473: Size comparison from 380d403 to 545f739 Increases (5 builds for cc13x2_26x2, esp32, nrfconnect, qpg, telink)
Decreases (3 builds for bl702, cc13x2_26x2, esp32)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23472
This change sets the
mIsFabricFiltered
param to false when MTRDevice does its wild card subscription.