Remove fixed code from callbacks-stubs.cpp generated files #23424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #23424: Size comparison from 16f49ea to 9dc7499 Increases above 0.2%:
Increases (8 builds for bl602, bl702, cc13x2_26x2, psoc6)
Decreases (3 builds for cc13x2_26x2, esp32)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Nov 2, 2022
yunhanw-google
approved these changes
Nov 2, 2022
Damian-Nordic
approved these changes
Nov 2, 2022
|
PR #23424: Size comparison from 16f49ea to ecad78a Increases above 0.2%:
Increases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, esp32, linux, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…hip#23424) * Move non-codegen callback stubs out of the zap template * Zap regen * Add generic-callback-stubs to cmake builds as well Co-authored-by: Andrei Litvin <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…hip#23424) * Move non-codegen callback stubs out of the zap template * Zap regen * Add generic-callback-stubs to cmake builds as well Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect generated code to depend mostly on generated inputs.
This splits out the non-codegen bits out of callback-stubs.cpp into its own stand-alone file. This makes callback-stubs smaller, less redundant (the same functions were weakly defined in both app and core data model classes) and maybe faster to generate/compile (unlikely to be meaningful though ... the only meaningful part is smaller and easier code to understand).