-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a fallback for the 'coloredlogs' import in 'codegen.py' #23411
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
mukifera:coloredlogs-optional-dep
Nov 2, 2022
Merged
add a fallback for the 'coloredlogs' import in 'codegen.py' #23411
bzbarsky-apple
merged 2 commits into
project-chip:master
from
mukifera:coloredlogs-optional-dep
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23411: Size comparison from eeb4cdc to 6441448 Increases (6 builds for bl702, cc13x2_26x2, esp32, k32w, telink)
Decreases (9 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, qpg)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 1, 2022
andy31415
approved these changes
Nov 1, 2022
pullapprove
bot
requested review from
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda and
msandstedt
November 1, 2022 15:23
PR #23411: Size comparison from 16f49ea to 4a62619 Increases (10 builds for bl602, bl702, psoc6, telink)
Decreases (1 build for cyw30739)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fallback for the
coloredlogs
python dependency inscripts/codegen.py
, makingcoloredlogs
an optional dependency.