Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull/nxp nxp smart lock demo app v2 #2340

Merged

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Aug 26, 2020

Allow building the NXP ELock Demo App by an external party:

  • sync Poject CHIP with the latest SDK for K32W platform;
  • allow using the OT submodule instead of prebuilt libs;
  • add build instructions for the ELock Demo App.

doru91 added 3 commits August 25, 2020 22:49
Make possible to build Project CHIP using a publicly available
SDK which can be downloaded from mcuxpresso.com.

Signed-off-by: Doru Gucea <[email protected]>
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_efr32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-efr32-lock-example.out and ./pull_artifact/chip-efr32-lock-example.out:

sections,vmsize,filesize
.debug_info,0,2437
.debug_loc,0,209
.debug_str,0,146
.strtab,0,130
.debug_line,0,19
[Unmapped],0,1
.debug_abbrev,0,-2
.debug_frame,0,-12
.debug_ranges,0,-24


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@doru91
Copy link
Contributor Author

doru91 commented Aug 28, 2020

I believe a third person needs to finally approve this PR. Thanks!

@pullapprove pullapprove bot requested a review from rwalker-apple August 28, 2020 07:21
@rwalker-apple
Copy link
Contributor

@mspang will you have a look?

@andy31415
Copy link
Contributor

@rwalker-apple I believe you need to add an extra approval since woody-apple does not have the lock anymore.
Also my lock moved to mspang ... so he may indeed need to reapprove as well.

@rwalker-apple rwalker-apple merged commit 8cfe391 into project-chip:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants