-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix crash when read/subscribe attribute API #23377
Merged
yufengwangca
merged 4 commits into
project-chip:master
from
joonhaengHeo:fix_wildcard_crash
Oct 31, 2022
Merged
[Android] Fix crash when read/subscribe attribute API #23377
yufengwangca
merged 4 commits into
project-chip:master
from
joonhaengHeo:fix_wildcard_crash
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
October 28, 2022 08:05
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
October 28, 2022 08:05
Damian-Nordic
approved these changes
Oct 28, 2022
PR #23377: Size comparison from 753cb9c to 9cc449d Increases (3 builds for cc13x2_26x2, psoc6)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, k32w, psoc6, telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Oct 29, 2022
yunhanw-google
approved these changes
Oct 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
PR #23377: Size comparison from 81a64dc to c901f4a Increases (9 builds for bl602, bl702, cc13x2_26x2, k32w, psoc6, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…3377) * Fix crash when read API in Android * Modify subscribe dialog UI * Restyle
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…3377) * Fix crash when read API in Android * Modify subscribe dialog UI * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview