-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fixing of package version from cirque #23372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
October 27, 2022 17:45
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
October 27, 2022 17:45
bzbarsky-apple
approved these changes
Oct 27, 2022
PR #23372: Size comparison from 51a5082 to 4407e2d Increases (4 builds for bl602, bl702, telink)
Decreases (6 builds for esp32, k32w, psoc6, qpg)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Oct 27, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Co-authored-by: Andrei Litvin <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Co-authored-by: Andrei Litvin <[email protected]>
cliffamzn
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Mar 15, 2023
Co-authored-by: Andrei Litvin <[email protected]>
cliffamzn
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Mar 16, 2023
Co-authored-by: Andrei Litvin <[email protected]>
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Mar 17, 2023
Co-authored-by: Andrei Litvin <[email protected]>
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Mar 17, 2023
Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cirque fixes various package versions and because the cirque base image is re-built every time, this means that it can perma-break whenever ubuntu base images are changed and old versions are removed.
This is not a problem with using dockerhub images (those versions are fixed in time ... but when we build new versions we can get these errors), but it is a problem for images build real-time.
We had to fix because of git before, now dbus is changed so I removed all versioning to make this less likely to break in time.