-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PASE/CASE session establishment response timeouts #23335
Update PASE/CASE session establishment response timeouts #23335
Conversation
PR #23335: Size comparison from 0d6c60f to 645f765 Increases above 0.2%:
Increases (14 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect)
Decreases (24 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
Full report (24 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
645f765
to
84164df
Compare
PR #23335: Size comparison from 0d6c60f to 84164df Increases above 0.2%:
Increases (20 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6)
Decreases (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add info regarding "the first message" to the docstrings for kInitial*
? Right now the description is the same for initial and not-initial, so on will have to see the code in order to understand what the initial actually means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #22193 for some discussion about this. We should perhaps have UseSuggestedResponseTimeout
right before the actual message sends we do, so there is no weird action at a distance.
84164df
to
da03cf7
Compare
PR #23335: Size comparison from a95dd6f to da03cf7 Increases above 0.2%:
Increases (20 builds for bl602, bl702, cc13x2_26x2, linux, mbed, nrfconnect, psoc6)
Decreases (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
da03cf7
to
6a84504
Compare
PR #23335: Size comparison from 96b4c0d to 6a84504 Increases above 0.2%:
Increases (21 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6)
Decreases (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Problem
PASE
/CASE
session establishment uses a default timeout of 30 seconds. This is way too long for the first message.This PR adds 2
constexpr
to configure a timeout for the "first" transmission, while the latter is for all the other messages.The reason for the first message to have its own defines it to allow failing fast if the peer is unreachable.