Clean up some unused ember methods from codegen & headers #23325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost and
kpschoedel
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #23325: Size comparison from d16182f to 86e0bec Increases (9 builds for bl602, bl702, linux, psoc6, telink)
Decreases (7 builds for bl602, bl702, psoc6)
Full report (24 builds for bl602, bl702, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 24, 2022
|
PR #23325: Size comparison from d16182f to 1955663 Increases (3 builds for bl702, linux)
Decreases (6 builds for bl602, bl702, telink)
Full report (24 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
turon
approved these changes
Oct 24, 2022
|
PR #23325: Size comparison from d16182f to 68ff901 Increases (9 builds for cc13x2_26x2, linux, psoc6)
Decreases (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ip#23325) * Remove ember Task* definitions and usages as they seem unused * Remove time-util functions as they do not seem used * Remove more seemingly unused/undefined method declarations * Zap regen * Removed more unused methods * Restyle * Remove a few more unused functions * Restyle * More dead code removal * Remove EmberNodeType and EmberChildData because unused * Removed emberAfClusterDefaultResponseCallback and emberAfClusterMessageSentCallback * Add comment for followup * Restyle
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ip#23325) * Remove ember Task* definitions and usages as they seem unused * Remove time-util functions as they do not seem used * Remove more seemingly unused/undefined method declarations * Zap regen * Removed more unused methods * Restyle * Remove a few more unused functions * Restyle * More dead code removal * Remove EmberNodeType and EmberChildData because unused * Removed emberAfClusterDefaultResponseCallback and emberAfClusterMessageSentCallback * Add comment for followup * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few methods which seem to be codegened as empty implementations and callbacks, however they never seem used inside our src. These seem ember legacy, so cleaning them up to have simpler codegen and simpler code overall.