Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark UnauthenticatedSession active when initiating a PASE session #23316

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Mark UnauthenticatedSession active when initiating a PASE session #23316

merged 1 commit into from
Oct 24, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

When the PASE session is started for commissioning it is idle. by default, which makes the MRP retransmission slower than what is should be.

This PR marks it as active.

@vivien-apple vivien-apple self-assigned this Oct 24, 2022
@github-actions
Copy link

github-actions bot commented Oct 24, 2022 •
edited
Loading

PR #23316: Size comparison from b9d32ec to cbf5da9

Increases (11 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, linux, psoc6)
platform target config section b9d32ec cbf5da9 change % change
bl602 lighting-app bl602 .text 1069834 1069836 2 0.0
bl702 lighting-app bl702 .debug_abbrev 1508924 1508964 40 0.0
.debug_info 37916953 37918011 1058 0.0
.debug_line 5257385 5257914 529 0.0
.debug_loc 3369084 3369484 400 0.0
.debug_ranges 358520 358664 144 0.0
bl702+rpc .debug_abbrev 1646331 1646371 40 0.0
.debug_info 41824009 41825067 1058 0.0
.debug_line 5632105 5632634 529 0.0
.debug_loc 3561786 3562186 400 0.0
.debug_ranges 380976 381120 144 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 641735 641743 8 0.0
.text 562488 562496 8 0.0
esp32 all-clusters-app c3devkit (read only) 1223866 1223868 2 0.0
(read/write) 1788334 1788342 8 0.0
.flash.rodata 257888 257896 8 0.0
.flash.text 1223866 1223868 2 0.0
k32w contact k32w0+release (read/write) 661396 661412 16 0.0
.text 563140 563156 16 0.0
linux chip-tool-ipv6only arm64 (read only) 10430852 10430932 80 0.0
.text 8257140 8257220 80 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_abbrev 1231397 1231442 45 0.0
.debug_info 26846916 26848541 1625 0.0
.debug_line 3673319 3673832 513 0.0
.debug_loc 3591948 3592717 769 0.0
.debug_ranges 338656 338864 208 0.1
all-clusters-minimal cy8ckit_062s2_43012 .debug_abbrev 1223196 1223241 45 0.0
.debug_info 26583669 26585293 1624 0.0
.debug_line 3694063 3694576 513 0.0
.debug_loc 3579585 3580354 769 0.0
.debug_ranges 337272 337480 208 0.1
light cy8ckit_062s2_43012 .debug_abbrev 1057288 1057333 45 0.0
.debug_info 22047121 22048746 1625 0.0
.debug_line 3263699 3264212 513 0.0
.debug_loc 3277297 3278066 769 0.0
.debug_ranges 302576 302784 208 0.1
lock cy8ckit_062s2_43012 .debug_abbrev 1059226 1059271 45 0.0
.debug_info 22280400 22282024 1624 0.0
.debug_line 3260683 3261196 513 0.0
.debug_loc 3304920 3305689 769 0.0
.debug_ranges 304512 304720 208 0.1
Decreases (6 builds for bl702, efr32, esp32, nrfconnect, telink)
platform target config section b9d32ec cbf5da9 change % change
bl702 lighting-app bl702+rpc .text 1031224 1031222 -2 -0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974220 974204 -16 -0.0
.text 819676 819660 -16 -0.0
esp32 all-clusters-app m5stack (read/write) 564260 564252 -8 -0.0
.flash.rodata 314960 314952 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 816016 816012 -4 -0.0
telink light-switch-app tlsr9518adk80d text 554016 554014 -2 -0.0
lighting-app tlsr9518adk80d text 566176 566174 -2 -0.0
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b9d32ec cbf5da9 change % change
bl602 lighting-app bl602 (read/write) 1390446 1390446 0 0.0
.bss 90745 90745 0 0.0
.data 9928 9928 0 0.0
.text 1069834 1069836 2 0.0
bl602+rpc (read/write) 1435662 1435662 0 0.0
.bss 98177 98177 0 0.0
.data 10312 10312 0 0.0
.text 1101182 1101182 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189427 1189427 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1508924 1508964 40 0.0
.debug_aranges 132088 132088 0 0.0
.debug_frame 484668 484668 0 0.0
.debug_info 37916953 37918011 1058 0.0
.debug_line 5257385 5257914 529 0.0
.debug_loc 3369084 3369484 400 0.0
.debug_ranges 358520 358664 144 0.0
.debug_str 3452369 3452369 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565491 565491 0 0.0
.symtab 171760 171760 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957778 957778 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285091 1285091 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1646331 1646371 40 0.0
.debug_aranges 139592 139592 0 0.0
.debug_frame 510040 510040 0 0.0
.debug_info 41824009 41825067 1058 0.0
.debug_line 5632105 5632634 529 0.0
.debug_loc 3561786 3562186 400 0.0
.debug_ranges 380976 381120 144 0.0
.debug_str 3848339 3848339 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624664 624664 0 0.0
.symtab 189568 189568 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031224 1031222 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677479 677479 0 0.0
(read/write) 174080 174080 0 0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89791 89791 0 0.0
.text 587376 587376 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641735 641743 8 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 78927 78927 0 0.0
.text 562488 562496 8 0.0
lock-ftd LP_CC2652R7 (read only) 675987 675987 0 0.0
(read/write) 172708 172708 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77315 77315 0 0.0
.text 598192 598192 0 0.0
lock-mtd LP_CC2652R7 (read only) 659743 659743 0 0.0
(read/write) 184640 184640 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103135 103135 0 0.0
.text 556128 556128 0 0.0
pump-app LP_CC2652R7 (read only) 688251 688251 0 0.0
(read/write) 161180 161180 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90763 90763 0 0.0
.text 597004 597004 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672535 672535 0 0.0
(read/write) 176992 176992 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86319 86319 0 0.0
.text 585736 585736 0 0.0
shell LP_CC2652R7 (read only) 668518 668518 0 0.0
(read/write) 185360 185360 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86502 86502 0 0.0
.text 581700 581700 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588258 588258 0 0.0
.app_xip_area 464844 464844 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592306 592306 0 0.0
.app_xip_area 463596 463596 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544126 544126 0 0.0
.app_xip_area 425792 425792 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974220 974204 -16 -0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 819676 819660 -16 -0.0
BRD4161A+rs911x (read/write) 1031784 1031784 0 0.0
.bss 186680 186680 0 0.0
.data 2092 2092 0 0.0
.text 842992 842992 0 0.0
BRD4187C (read/write) 1146500 1146500 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980644 980644 0 0.0
lock-app BRD4161A+wf200 (read/write) 1157376 1157376 0 0.0
.bss 158208 158208 0 0.0
.data 2100 2100 0 0.0
.text 997048 997048 0 0.0
window-app BRD4187C (read/write) 1139720 1139720 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972424 972424 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223866 1223868 2 0.0
(read/write) 1788334 1788342 8 0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257888 257896 8 0.0
.flash.text 1223866 1223868 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233807 1233807 0 0.0
(read/write) 564260 564252 -8 -0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314960 314952 -8 -0.0
.flash.text 1228423 1228423 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661396 661412 16 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563140 563156 16 0.0
light k32w0+release (read/write) 671640 671640 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592012 592012 0 0.0
lock k32w0+release (read/write) 633220 633220 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552812 552812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10430852 10430932 80 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518148 518148 0 0.0
.text 8257140 8257220 80 0.0
thermostat-no-ble arm64 (read only) 2391420 2391420 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144484 144484 0 0.0
.text 2004032 2004032 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452328 2452328 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414972 1414972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183787 1183787 0 0.0
bss 144457 144457 0 0.0
rodata 144428 144428 0 0.0
text 816016 816012 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162471 1162471 0 0.0
bss 143684 143684 0 0.0
rodata 136000 136000 0 0.0
text 803912 803912 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745804 1745804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1231397 1231442 45 0.0
.debug_aranges 110824 110824 0 0.0
.debug_frame 371524 371524 0 0.0
.debug_info 26846916 26848541 1625 0.0
.debug_line 3673319 3673832 513 0.0
.debug_loc 3591948 3592717 769 0.0
.debug_ranges 338656 338864 208 0.1
.debug_str 3436383 3436383 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570037 570037 0 0.0
.symtab 421376 421376 0 0.0
.text 1546024 1546024 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688404 1688404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1223196 1223241 45 0.0
.debug_aranges 110296 110296 0 0.0
.debug_frame 374604 374604 0 0.0
.debug_info 26583669 26585293 1624 0.0
.debug_line 3694063 3694576 513 0.0
.debug_loc 3579585 3580354 769 0.0
.debug_ranges 337272 337480 208 0.1
.debug_str 3425404 3425404 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534126 534126 0 0.0
.symtab 407808 407808 0 0.0
.text 1489360 1489360 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1606932 1606932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1057288 1057333 45 0.0
.debug_aranges 102504 102504 0 0.0
.debug_frame 344936 344936 0 0.0
.debug_info 22047121 22048746 1625 0.0
.debug_line 3263699 3264212 513 0.0
.debug_loc 3277297 3278066 769 0.0
.debug_ranges 302576 302784 208 0.1
.debug_str 3230924 3230924 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470503 470503 0 0.0
.symtab 376256 376256 0 0.0
.text 1416072 1416072 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640620 1640620 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1059226 1059271 45 0.0
.debug_aranges 102896 102896 0 0.0
.debug_frame 346792 346792 0 0.0
.debug_info 22280400 22282024 1624 0.0
.debug_line 3260683 3261196 513 0.0
.debug_loc 3304920 3305689 769 0.0
.debug_ranges 304512 304720 208 0.1
.debug_str 3250318 3250318 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472854 472854 0 0.0
.symtab 377872 377872 0 0.0
.text 1444768 1444768 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148952 1148952 0 0.0
.bss 110580 110580 0 0.0
.data 832 832 0 0.0
.text 596052 596052 0 0.0
lock-app qpg6105+debug (read/write) 1113840 1113840 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560936 560936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790476 790476 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 554016 554014 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 805732 805732 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 566176 566174 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 804616 804616 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 565044 565044 0 0.0

@vivien-apple vivien-apple merged commit 82bcb39 into project-chip:master Oct 24, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@vivien-apple @adbridge
Mark UnauthenticatedSession active when initiating a PASE session (pr…
0696c12 
…oject-chip#23316)
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@vivien-apple @adbridge
Mark UnauthenticatedSession active when initiating a PASE session (pr…
4358eb0 
…oject-chip#23316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @bzbarsky-apple @Damian-Nordic