-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dnssd] Sort IPs by scores for commissionable node discovery #23292
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Dnssd_SortIPsByScore
Oct 21, 2022
Merged
[Dnssd] Sort IPs by scores for commissionable node discovery #23292
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Dnssd_SortIPsByScore
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
October 21, 2022 14:09
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
October 21, 2022 14:09
PR #23292: Size comparison from 66c0270 to d843881 Increases (4 builds for bl602, linux)
Full report (4 builds for bl602, linux)
|
andy31415
reviewed
Oct 21, 2022
woody-apple
approved these changes
Oct 21, 2022
vivien-apple
force-pushed
the
Dnssd_SortIPsByScore
branch
from
October 21, 2022 18:22
d843881
to
54664e4
Compare
PR #23292: Size comparison from 559c7d5 to 54664e4 Increases (31 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (31 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 21, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While address resolution for CASE session establishment is scoring IPs to "guess" the best IP, the commissionable discovery bits does not.
Proposed solution
Score IPs for commissionable bits too by moving one layer up the scoring code. It can still be overridden by implementing a custom logic in
LookupResult
but by default it will be scored against a default scoring heuristic.The whole addresses array is sorted in case one wants to try multiple IPs for connecting to a device instead of only returning the "best" IP.