-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Added multi-admin documentation to CHIPTool guide. #23290
Merged
LuDuda
merged 2 commits into
project-chip:master
from
kkasperczyk-no:chiptool_multiadmin_guide
Oct 26, 2022
Merged
[docs] Added multi-admin documentation to CHIPTool guide. #23290
LuDuda
merged 2 commits into
project-chip:master
from
kkasperczyk-no:chiptool_multiadmin_guide
Oct 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 21, 2022
kkasperczyk-no
force-pushed
the
chiptool_multiadmin_guide
branch
3 times, most recently
from
October 21, 2022 12:52
26d4871
to
7206d48
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda and
mlepage-google
October 21, 2022 12:52
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
October 21, 2022 12:52
kkasperczyk-no
force-pushed
the
chiptool_multiadmin_guide
branch
from
October 21, 2022 12:54
7206d48
to
f1b5dfc
Compare
Extended CHIPTool guide by multi-admin scenario section, describing how to open commissioning window on a device and pair in to the new fabric.
kkasperczyk-no
force-pushed
the
chiptool_multiadmin_guide
branch
from
October 21, 2022 13:01
f1b5dfc
to
bff405c
Compare
arkq
approved these changes
Oct 21, 2022
PR #23290: Size comparison from 66c0270 to bff405c Increases (6 builds for cc13x2_26x2, esp32, k32w, psoc6)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
markaj-nordic
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added minor suggestions.
andy31415
approved these changes
Oct 21, 2022
kkasperczyk-no
force-pushed
the
chiptool_multiadmin_guide
branch
2 times, most recently
from
October 24, 2022 09:02
168b75d
to
df39cad
Compare
kkasperczyk-no
force-pushed
the
chiptool_multiadmin_guide
branch
from
October 24, 2022 09:27
df39cad
to
d60bfc4
Compare
PR #23290: Size comparison from b9d32ec to d60bfc4 Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, psoc6, telink)
Decreases (2 builds for esp32, nrfconnect)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
LuDuda
approved these changes
Oct 26, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ip#23290) * [docs] Added multi-admin documentation to CHIPTool guide. Extended CHIPTool guide by multi-admin scenario section, describing how to open commissioning window on a device and pair in to the new fabric. * Addressed review comments
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ip#23290) * [docs] Added multi-admin documentation to CHIPTool guide. Extended CHIPTool guide by multi-admin scenario section, describing how to open commissioning window on a device and pair in to the new fabric. * Addressed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended CHIPTool guide by multi-admin scenario section, describing how to open commissioning window on a device and pair it to the new fabric.