-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Disable unnecessary reconnection for ConnectNetwork command #23251
Merged
andy31415
merged 2 commits into
project-chip:master
from
wqx6:unnecessary-reconnect-esp32
Oct 20, 2022
Merged
ESP32: Disable unnecessary reconnection for ConnectNetwork command #23251
andy31415
merged 2 commits into
project-chip:master
from
wqx6:unnecessary-reconnect-esp32
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23251: Size comparison from c279578 to 6c9375e Increases (2 builds for esp32)
Decreases (7 builds for bl602, bl702, esp32, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
approved these changes
Oct 19, 2022
6c9375e
to
b542586
Compare
PR #23251: Size comparison from c279578 to b542586 Decreases (2 builds for bl702)
Full report (3 builds for bl702, mbed)
|
andy31415
approved these changes
Oct 19, 2022
PR #23251: Size comparison from e4f60ce to 8dab760 Decreases (3 builds for bl602, bl702, telink)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 20, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23251) Co-authored-by: Andrei Litvin <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23251) Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23250