-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable shorten 64 to 32 error for arm64 (do not make it fatal) #23237
Merged
andy31415
merged 4 commits into
project-chip:master
from
andy31415:fix_arm64_cross_compile
Oct 18, 2022
Merged
Disable shorten 64 to 32 error for arm64 (do not make it fatal) #23237
andy31415
merged 4 commits into
project-chip:master
from
andy31415:fix_arm64_cross_compile
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
October 17, 2022 21:53
pullapprove
bot
requested review from
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
October 17, 2022 21:53
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
October 17, 2022 21:53
bzbarsky-apple
approved these changes
Oct 17, 2022
PR #23237: Size comparison from b9cf4b9 to 6e5ded9 Decreases (2 builds for bl702)
Full report (7 builds for bl702, k32w, qpg)
|
fast track after approx 1day because this fixes a build failure. |
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ect-chip#23237) * Disable shorten 64 to 32 error for arm64 (do not make it fatal) * Add a CI target that would catch these errors in future updates * Restyle * Fix typo and link to the pigweed update PR
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ect-chip#23237) * Disable shorten 64 to 32 error for arm64 (do not make it fatal) * Add a CI target that would catch these errors in future updates * Restyle * Fix typo and link to the pigweed update PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arm64 builds like
./scripts/build/build_examples.py --target linux-arm64-light-rpc-ipv6only-clang build
were failing because pigweed casting errors in pw_tokenizer and pw_rpc.Since pigweed updates take a bit (need some build system updates after the 1.0 freeze), I am disabling these errors for linux+arm64 (but we keep them for other platforms, so hopefully we keep having good code).
Fixes #23238