Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EFR cloudbuild smoke tests, add more targets #23236

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Fix EFR cloudbuild smoke tests, add more targets #23236

merged 3 commits into from
Oct 18, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Oct 17, 2022 •
edited
Loading

Updated a few build_example-related items:

  • cloudbuild smoketest had a copy & paste issue and was building nrf builds when it was claiming EFR builds. Fixed that
  • target.py string splitting was not considering all iterators due to filter usage. Changed it to create list in-place
  • added min-mdns verbose variant for linux-arm64 builds as well.
  • light-rpc was parsed as a separate app, when rpc seems to actually be a modifier. Moved rpc as a modifier.

@github-actions
Copy link

PR #23236: Size comparison from 57a8bfa to 136e857

Increases (1 build for bl702)
platform target config section 57a8bfa 136e857 change % change
bl702 lighting-app bl702+rpc .debug_info 41812027 41812028 1 0.0
.text 1030504 1030506 2 0.0
Full report (4 builds for bl702, linux)
platform target config section 57a8bfa 136e857 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188691 1188691 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506865 1506865 0 0.0
.debug_aranges 133136 133136 0 0.0
.debug_frame 486600 486600 0 0.0
.debug_info 37905413 37905413 0 0.0
.debug_line 5256822 5256822 0 0.0
.debug_loc 3367145 3367145 0 0.0
.debug_ranges 359376 359376 0 0.0
.debug_str 3457811 3457811 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565071 565071 0 0.0
.symtab 171664 171664 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957058 957058 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284355 1284355 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75150 75150 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644410 1644410 0 0.0
.debug_aranges 140640 140640 0 0.0
.debug_frame 511972 511972 0 0.0
.debug_info 41812027 41812028 1 0.0
.debug_line 5631353 5631353 0 0.0
.debug_loc 3559792 3559792 0 0.0
.debug_ranges 381832 381832 0 0.0
.debug_str 3853711 3853711 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624244 624244 0 0.0
.symtab 189472 189472 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030504 1030506 2 0.0
linux chip-tool-ipv6only arm64 (read only) 10429476 10429476 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518132 518132 0 0.0
.text 8255780 8255780 0 0.0
thermostat-no-ble arm64 (read only) 2390524 2390524 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144436 144436 0 0.0
.text 2003184 2003184 0 0.0

@github-actions
Copy link

PR #23236: Size comparison from 57a8bfa to ee93012

Increases (7 builds for bl702, k32w, nrfconnect, qpg, telink)
platform target config section 57a8bfa ee93012 change % change
bl702 lighting-app bl702 (read/write) 1188691 1188963 272 0.0
.bss 67102 67118 16 0.0
.debug_abbrev 1506865 1507059 194 0.0
.debug_aranges 133136 133144 8 0.0
.debug_frame 486600 486648 48 0.0
.debug_info 37905413 37908924 3511 0.0
.debug_line 5256822 5257423 601 0.0
.debug_loc 3367145 3367638 493 0.0
.debug_ranges 359376 359456 80 0.0
.debug_str 3457811 3457927 116 0.0
.strtab 565071 565127 56 0.0
.symtab 171664 171680 16 0.0
.text 957058 957314 256 0.0
bl702+rpc (read/write) 1284355 1284627 272 0.0
.bss 75150 75166 16 0.0
.debug_abbrev 1644410 1644604 194 0.0
.debug_aranges 140640 140648 8 0.0
.debug_frame 511972 512020 48 0.0
.debug_info 41812027 41815539 3512 0.0
.debug_line 5631353 5631954 601 0.0
.debug_loc 3559792 3560285 493 0.0
.debug_ranges 381832 381912 80 0.0
.debug_str 3853711 3853897 186 0.0
.strtab 624244 624300 56 0.0
.symtab 189472 189488 16 0.0
.text 1030504 1030760 256 0.0
k32w light k32w0+release (read/write) 671280 671480 200 0.0
.bss 74816 74840 24 0.0
.text 591676 591852 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183451 1183627 176 0.0
bss 144441 144457 16 0.0
text 815708 815888 180 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162119 1162311 192 0.0
bss 143668 143684 16 0.0
text 803600 803780 180 0.0
qpg lighting-app qpg6105+debug (read/write) 1148632 1148808 176 0.0
.bss 110556 110580 24 0.0
.text 595732 595908 176 0.0
telink lighting-app tlsr9518adk80d (read/write) 811476 811684 208 0.0
bss 73328 73344 16 0.0
text 571358 571554 196 0.0
Decreases (5 builds for k32w, qpg, telink)
platform target config section 57a8bfa ee93012 change % change
k32w contact k32w0+release (read/write) 661284 661268 -16 -0.0
.text 563028 563012 -16 -0.0
lock k32w0+release (read/write) 633092 633076 -16 -0.0
.text 552684 552668 -16 -0.0
qpg lock-app qpg6105+debug (read/write) 1113712 1113696 -16 -0.0
.text 560808 560792 -16 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 789364 789356 -8 -0.0
text 553138 553132 -6 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 819412 819404 -8 -0.0
text 577544 577536 -8 -0.0
Full report (15 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 57a8bfa ee93012 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188691 1188963 272 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67118 16 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506865 1507059 194 0.0
.debug_aranges 133136 133144 8 0.0
.debug_frame 486600 486648 48 0.0
.debug_info 37905413 37908924 3511 0.0
.debug_line 5256822 5257423 601 0.0
.debug_loc 3367145 3367638 493 0.0
.debug_ranges 359376 359456 80 0.0
.debug_str 3457811 3457927 116 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565071 565127 56 0.0
.symtab 171664 171680 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957058 957314 256 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284355 1284627 272 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75150 75166 16 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644410 1644604 194 0.0
.debug_aranges 140640 140648 8 0.0
.debug_frame 511972 512020 48 0.0
.debug_info 41812027 41815539 3512 0.0
.debug_line 5631353 5631954 601 0.0
.debug_loc 3559792 3560285 493 0.0
.debug_ranges 381832 381912 80 0.0
.debug_str 3853711 3853897 186 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624244 624300 56 0.0
.symtab 189472 189488 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030504 1030760 256 0.0
k32w contact k32w0+release (read/write) 661284 661268 -16 -0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563028 563012 -16 -0.0
light k32w0+release (read/write) 671280 671480 200 0.0
.bss 74816 74840 24 0.0
.data 2060 2060 0 0.0
.text 591676 591852 176 0.0
lock k32w0+release (read/write) 633092 633076 -16 -0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552684 552668 -16 -0.0
linux chip-tool-ipv6only arm64 (read only) 10429476 10429476 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518132 518132 0 0.0
.text 8255780 8255780 0 0.0
thermostat-no-ble arm64 (read only) 2390524 2390524 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144436 144436 0 0.0
.text 2003184 2003184 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452168 2452168 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414812 1414812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183451 1183627 176 0.0
bss 144441 144457 16 0.0
rodata 144396 144396 0 0.0
text 815708 815888 180 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162119 1162311 192 0.0
bss 143668 143684 16 0.0
rodata 135968 135968 0 0.0
text 803600 803780 180 0.0
qpg lighting-app qpg6105+debug (read/write) 1148632 1148808 176 0.0
.bss 110556 110580 24 0.0
.data 832 832 0 0.0
.text 595732 595908 176 0.0
lock-app qpg6105+debug (read/write) 1113712 1113696 -16 -0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560808 560792 -16 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 789364 789356 -8 -0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553138 553132 -6 -0.0
lighting-app tlsr9518adk80d (read/write) 811476 811684 208 0.0
bss 73328 73344 16 0.0
noinit 43520 43520 0 0.0
text 571358 571554 196 0.0
ota-requestor-app tlsr9518adk80d (read/write) 819412 819404 -8 -0.0
bss 74236 74236 0 0.0
noinit 43520 43520 0 0.0
text 577544 577536 -8 -0.0

@andy31415 andy31415 enabled auto-merge (squash) October 18, 2022 15:30
@andy31415 andy31415 merged commit 9c128b0 into project-chip:master Oct 18, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@andy31415 @adbridge
Fix EFR cloudbuild smoke tests, add more targets (project-chip#23236)
5332700 
* Fix some smoke test target options

* Restyle

* Fix unit tests
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@andy31415 @adbridge
Fix EFR cloudbuild smoke tests, add more targets (project-chip#23236)
2b3df5b 
* Fix some smoke test target options

* Restyle

* Fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tehampson tehampson tehampson approved these changes

@mspang mspang mspang approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
integrations review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @mspang @tehampson @bzbarsky-apple