-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add configurable ep1 ACLs and bindings #23212
Conversation
PR #23212: Size comparison from 9f08fc1 to d9523e4 Increases (2 builds for psoc6)
Decreases (3 builds for nrfconnect, psoc6)
Full report (20 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, psoc6)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One thing that can be done at a later point is to create an object for the callbacks and pass the context to that object instead of caching it in the listener object which we create only one instance of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
* Draft: Add configurable ep1 ACLs and bindings * address comments
* Draft: Add configurable ep1 ACLs and bindings * address comments
* Draft: Add configurable ep1 ACLs and bindings * address comments
Fixes #23208
After commissioning a casting video client using ContentAppPlatform::ManageClientAccess
This PR allows the ContentAppPlatformFactory to set the cluster list on ep1, and pass a binding list to ManageClientAccess.
The linux and android example tv-apps all read the current binding list and perform a merge rather than replacement of bindings.