-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gn] add zephyr platform to gn build system #2320
Conversation
6d7d088
to
1437178
Compare
@@ -49,7 +49,6 @@ if (chip_device_platform != "none" && chip_device_platform != "external") { | |||
chip_device_config_enable_wpa = chip_enable_wifi | |||
|
|||
defines = [ | |||
"CHIP_DEVICE_CONFIG_ENABLE_THREAD=${chip_enable_openthread}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed this define deliberately.
I think it would be good to have this define set in CHIPDevicePlatformConfig.h
, because we can use Kconfig defines directly there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be changing behavior on all CHIP platforms, not just nrfconnect. @mspang ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems fine, that's why there's a change to src/platform/EFR32/CHIPDevicePlatformConfig.h in this PR.
5d305e2
to
b87dc8a
Compare
@e-rk will you resolve conflicts, here? |
@rwalker-apple Done. |
146e3c3
to
753f725
Compare
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "gn_efr32-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Problem
Zephyr platform doesn't use GN.
Summary of Changes
This PR adds basic support for GN build system with Zephyr build environment.
fixes #2225