Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DNS-SD advertisements on fail-safe timeout #23199

Merged
merged 5 commits into from
Oct 18, 2022
Merged

Update DNS-SD advertisements on fail-safe timeout #23199

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f9ccd9
Update DNS-SD advertisements on fail-safe timeout
msandstedt Oct 14, 2022
babf5cc
Merge branch 'master' into bugfix/23169
msandstedt Oct 14, 2022
309693d
Merge branch 'master' into bugfix/23169
msandstedt Oct 14, 2022
fe4062e
Merge branch 'master' into bugfix/23169
msandstedt Oct 17, 2022
9fbf6f6
Merge branch 'master' into bugfix/23169
msandstedt Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,6 @@ const FabricInfo * RetrieveCurrentFabric(CommandHandler * aCommandHandler)
CHIP_ERROR DeleteFabricFromTable(FabricIndex fabricIndex)
{
ReturnErrorOnFailure(Server::GetInstance().GetFabricTable().Delete(fabricIndex));

// We need to withdraw the advertisement for the now-removed fabric, so need
// to restart advertising altogether.
app::DnssdServer::Instance().StartServer();

return CHIP_NO_ERROR;
}

Expand Down Expand Up @@ -362,6 +357,10 @@ class OpCredsFabricTableDelegate : public chip::FabricTable::Delegate
{
ChipLogProgress(Zcl, "OpCreds: Fabric index 0x%x was removed", static_cast<unsigned>(fabricIndex));

// We need to withdraw the advertisement for the now-removed fabric, so need
// to restart advertising altogether.
app::DnssdServer::Instance().StartServer();

EventManagement::GetInstance().FabricRemoved(fabricIndex);

NotifyFabricTableChanged();
Expand Down