-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: Remove unused config option CHIP_DEVICE_CONFIG_LOG_PROVISIONING_HASH #23166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
October 13, 2022 10:35
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
October 13, 2022 10:35
github-actions
bot
added
config
darwin
efr32
esp32
linux
nrf connect
platform
telink
zephyr
labels
Oct 13, 2022
pullapprove
bot
removed
platform
darwin
efr32
esp32
linux
nrf connect
zephyr
config
telink
labels
Oct 13, 2022
PR #23166: Size comparison from 2c9cd92 to c0b3e90 Increases (7 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (5 builds for esp32, nrfconnect, psoc6)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 13, 2022
dhrishi
approved these changes
Oct 14, 2022
Damian-Nordic
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grep the repository with following command and could not find any usage for
CHIP_DEVICE_CONFIG_LOG_PROVISIONING_HASH