[Tizen] Do not notify the resolve error of dnssd #23156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hyunuk.tak <[email protected]>
hyunuktak
changed the title
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #23156: Size comparison from 910218a to 640a69e Increases (3 builds for bl602, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
harsha-rajendran
approved these changes
Oct 13, 2022
|
@hyunuktak - please explain "It can cause a collision in the caller's user callback." |
andy31415
requested changes
Oct 13, 2022
There was a problem hiding this comment.
Description of issue does not help me understand the problem and the fix.
I see a notification of error being removed, but I am unclear of why this is causing problems and why removing the error notification is the correct thing to do.
Silent error never seem ok. At least a log seems apropriate, but a callback of "error happened" seems even better.
Please make sure that your PR description is clear to understand for reviewers.
It seems that the explanation was insufficient. |
The explanation is still vague. I do not understand it. The way I read it is: "An error is reported when resoltion fails, but this may cause an error to the user like double free". Why don't you fix the double free then? Fix on the other side. Reporting an error when an error occurs is ok. |
|
If you fix it, make the user properly handle the cleanup of the data. This seems to be a bug in the user usage of resolution not in the implementation of error handling. |
|
I guess explanation could be done by example: Linux avahi: https://github.com/project-chip/connectedhomeip/blob/master/src/platform/Linux/DnssdImpl.cpp#L693 does NOT callback error on failure Darwin: https://github.com/project-chip/connectedhomeip/blob/master/src/platform/Darwin/DnssdImpl.cpp#L344 does NOT callback on failure. I will update the summary |
andy31415
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DNSSD Platform contract does not expect callback to be called from within the Resolve call. In particular, the
::Resolveerror state is already returned as a return code of the method and does not need to be re-iterated within the callback (doing so seems to result in double-error handling)For reference, at least the linux-avahi and darwin implementations also do not call the callback if an error occurs within the resolve initiation.
Change overview
Remove a notification about resolve error of dnssd.
Testing
chip-tool and chip-lighting-app examples