Implementation of the ManualSetupPayloadGenerator/Parser #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
|
Additional reviewers @bhaskar-apple @rwalker-apple @sagar-apple |
woody-apple
requested changes
Apr 2, 2020
bhaskar-apple
suggested changes
Apr 2, 2020
sagar-apple
reviewed
Apr 2, 2020
pan-apple
reviewed
Apr 2, 2020
woody-apple
approved these changes
Apr 7, 2020
bhaskar-apple
previously approved these changes
Apr 8, 2020
gerickson
approved these changes
Apr 8, 2020
shana-apple
force-pushed
the
sazria/manualSetupPayloadGeneratorAndParser
branch
from
2eb4da8 to
c38a515
Compare
|
@BroderickCarlin or @hawk248 can we get some eyes on this? Sounds like the TT has completed iteration in this block. |
hawk248
approved these changes
Apr 9, 2020
…oadParser along with unit tests
shana-apple
force-pushed
the
sazria/manualSetupPayloadGeneratorAndParser
branch
from
c38a515 to
fab35b4
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* [SL-UP] Add provisioning root argument (#231) * Restyled by gn --------- Co-authored-by: Restyled.io <[email protected]>
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the ManualSetupPayloadGenerator which generates a decimal string from the manual setup payload.
Implemented the ManualSetupPayloadParser which populates a manual setup payload from a decimal string
Added unit tests
Here is the PR against my fork's master to confirm this builds correctly:
shana-apple#1