Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct string value for kResume1MIC_Nonce #23098

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

mfucci
Copy link
Contributor

@mfucci mfucci commented Oct 10, 2022

{ 0x4e, 0x43, 0x41, 0x53, 0x45, 0x5f, 0x53, 0x69, 0x67, 0x6d, 0x61, 0x53, 0x31 } bytes represent "NCASE_SigmaS1" string, not "NCASE_SigmaR1"

This change only corrects the comment and will have no functional change.

{ 0x4e, 0x43, 0x41, 0x53, 0x45, 0x5f, 0x53, 0x69, 0x67, 0x6d, 0x61, 0x53, 0x31 } bytes represent "NCASE_SigmaS1" string, not "NCASE_SigmaR1"
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 10, 2022

PR #23098: Size comparison from 119cdf5 to 49ed12d

Increases (1 build for bl602)
platform target config section 119cdf5 49ed12d change % change
bl602 lighting-app bl602+rpc (read/write) 1434866 1434874 8 0.0
.text 1100408 1100410 2 0.0
Decreases (1 build for telink)
platform target config section 119cdf5 49ed12d change % change
telink light-switch-app tlsr9518adk80d text 553144 553142 -2 -0.0
Full report (16 builds for bl602, bl702, k32w, linux, nrfconnect, qpg, telink)
platform target config section 119cdf5 49ed12d change % change
bl602 lighting-app bl602 (read/write) 1389654 1389654 0 0.0
.bss 90729 90729 0 0.0
.data 9928 9928 0 0.0
.text 1069060 1069060 0 0.0
bl602+rpc (read/write) 1434866 1434874 8 0.0
.bss 98161 98161 0 0.0
.data 10312 10312 0 0.0
.text 1100408 1100410 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188659 1188659 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506865 1506865 0 0.0
.debug_aranges 133128 133128 0 0.0
.debug_frame 486580 486580 0 0.0
.debug_info 37905288 37905288 0 0.0
.debug_line 5256840 5256840 0 0.0
.debug_loc 3367112 3367112 0 0.0
.debug_ranges 359368 359368 0 0.0
.debug_str 3457811 3457811 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565071 565071 0 0.0
.symtab 171664 171664 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957032 957032 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284579 1284579 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75150 75150 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644410 1644410 0 0.0
.debug_aranges 140632 140632 0 0.0
.debug_frame 511956 511956 0 0.0
.debug_info 41811901 41811901 0 0.0
.debug_line 5631375 5631375 0 0.0
.debug_loc 3559772 3559772 0 0.0
.debug_ranges 381824 381824 0 0.0
.debug_str 3853711 3853711 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624244 624244 0 0.0
.symtab 189472 189472 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030734 1030734 0 0.0
k32w contact k32w0+release (read/write) 666088 666088 0 0.0
.bss 77048 77048 0 0.0
.data 2108 2108 0 0.0
.text 567820 567820 0 0.0
light k32w0+release (read/write) 641812 641812 0 0.0
.bss 74824 74824 0 0.0
.data 2064 2064 0 0.0
.text 562196 562196 0 0.0
lock k32w0+release (read/write) 633092 633092 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552684 552684 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10429892 10429892 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518164 518164 0 0.0
.text 8256164 8256164 0 0.0
thermostat-no-ble arm64 (read only) 2390428 2390428 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144436 144436 0 0.0
.text 2003088 2003088 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183451 1183451 0 0.0
bss 144441 144441 0 0.0
rodata 144396 144396 0 0.0
text 815708 815708 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162119 1162119 0 0.0
bss 143668 143668 0 0.0
rodata 135968 135968 0 0.0
text 803600 803600 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148656 1148656 0 0.0
.bss 110556 110556 0 0.0
.data 832 832 0 0.0
.text 595756 595756 0 0.0
lock-app qpg6105+debug (read/write) 1113720 1113720 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560816 560816 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789372 789372 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553144 553142 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 811484 811484 0 0.0
bss 73328 73328 0 0.0
noinit 43520 43520 0 0.0
text 571366 571366 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 819420 819420 0 0.0
bss 74236 74236 0 0.0
noinit 43520 43520 0 0.0
text 577548 577548 0 0.0

@bzbarsky-apple
Copy link
Contributor

I filed https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/5661 to get this fixed in the spec.

selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Oct 12, 2022
{ 0x4e, 0x43, 0x41, 0x53, 0x45, 0x5f, 0x53, 0x69, 0x67, 0x6d, 0x61, 0x53, 0x31 } bytes represent "NCASE_SigmaS1" string, not "NCASE_SigmaR1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants