-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] The objc subscription callback bridge is leaked for single attribute subscriptions #23061
[Darwin] The objc subscription callback bridge is leaked for single attribute subscriptions #23061
Conversation
Rebased to latest master to try to get around some build issues |
PR #23061: Size comparison from 26dab6c to 99532fc Decreases (2 builds for bl702)
Full report (3 builds for bl702, mbed)
|
PR #23061: Size comparison from 26dab6c to d65629b Increases (9 builds for bl702, cc13x2_26x2, linux, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, qpg, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
d65629b
to
803f9a6
Compare
Rebased on master to be in-line with the recent reverts and changes. |
PR #23061: Size comparison from ac19e88 to 803f9a6 Increases (4 builds for linux, psoc6)
Decreases (10 builds for bl602, bl702, linux, psoc6, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23061: Size comparison from ac19e88 to 7f620a2 Increases (8 builds for bl602, linux, psoc6)
Decreases (8 builds for linux, psoc6, telink)
Full report (29 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23061: Size comparison from ac19e88 to 7c138fb Increases (4 builds for bl702, linux)
Decreases (5 builds for bl702, linux, telink)
Full report (15 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
05cf8f6
to
b47a498
Compare
PR #23061: Size comparison from a35ee1b to b47a498 Increases (9 builds for bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, k32w, linux, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23061: Size comparison from a35ee1b to 06e5b5f Increases (12 builds for bl602, bl702, cyw30739, k32w, linux, psoc6, qpg, telink)
Decreases (7 builds for linux, nrfconnect, psoc6)
Full report (31 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23061: Size comparison from a35ee1b to 016c9ac Increases (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl702, cc13x2_26x2, linux, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
987d5ce
to
5dde686
Compare
Squashed and rebased on latest master because previous build somehow didn't pick up the latest overall darwin build timeout change. |
PR #23061: Size comparison from b9d32ec to 5dde686 Increases (8 builds for bl602, cc13x2_26x2, esp32, k32w, linux, psoc6)
Decreases (10 builds for bl702, esp32, linux, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
5dde686
to
17e3e42
Compare
PR #23061: Size comparison from 911d5f4 to 17e3e42 Increases (6 builds for bl602, esp32, linux, psoc6)
Decreases (10 builds for bl602, bl702, cyw30739, esp32, linux, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ttribute subscriptions (project-chip#23061) * [Darwin] The objc subscription callback bridge is leaked for single attribute subscriptions * increase overall darwin build time
…ttribute subscriptions (project-chip#23061) * [Darwin] The objc subscription callback bridge is leaked for single attribute subscriptions * increase overall darwin build time
Fixes #22333
In the Darwin framework, a "callback bridge" object is leaked because there's no current way to reference it when a single attribute subscription is done.
This change adds optional plumbing to pass a callback for OnDone as a std::function, and that gives the Darwin framework opportunity to capture the pointer for deletion at OnDone time.