-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick Add contact-sensor-app (#22966) #23047
Merged
andy31415
merged 2 commits into
project-chip:v1.0-branch
from
NXP:cp-add-contact-sensor
Oct 19, 2022
Merged
Cherry-pick Add contact-sensor-app (#22966) #23047
andy31415
merged 2 commits into
project-chip:v1.0-branch
from
NXP:cp-add-contact-sensor
Oct 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-menzopol
force-pushed
the
cp-add-contact-sensor
branch
from
October 6, 2022 12:58
5225424
to
2e6cc57
Compare
PR #23047: Size comparison from 83123f8 to 2e6cc57 Increases (3 builds for esp32, psoc6)
Decreases (4 builds for bl602, bl702, cyw30739)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@andrei-menzopol - why is this required in the 1.0 branch? |
We would like to support the contact sensor app on this v1.0 branch too. |
andrei-menzopol
force-pushed
the
cp-add-contact-sensor
branch
from
October 11, 2022 06:54
2e6cc57
to
95d8be1
Compare
PR #23047: Size comparison from 26a054c to 95d8be1 Increases (2 builds for esp32, qpg)
Decreases (6 builds for bl602, esp32, nrfconnect, psoc6, qpg, telink)
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andrei-menzopol
force-pushed
the
cp-add-contact-sensor
branch
from
October 14, 2022 06:49
95d8be1
to
e2e4fc2
Compare
PR #23047: Size comparison from 4589a52 to e2e4fc2 Increases (5 builds for bl702, esp32, psoc6, telink)
Decreases (3 builds for bl602, esp32, k32w)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* [K32W0] Add contact-sensor-app * Add K32W0 contact-sensor-app * Add contact-sensor-app-common files * Generate zap-files Signed-off-by: Ethan Tan <[email protected]> Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Restyled by prettier-markdown * Fix zap file & misspell Signed-off-by: Andrei Menzopol <[email protected]> * Update matter, zap files and regenerate contact-sensor-app/zap-generated Signed-off-by: Andrei Menzopol <[email protected]> * Add contact-sensor build changes Signed-off-by: Andrei Menzopol <[email protected]> * Update contact-sensor-app matter file Signed-off-by: Andrei Menzopol <[email protected]> Signed-off-by: Ethan Tan <[email protected]> Signed-off-by: Andrei Menzopol <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
andrei-menzopol
force-pushed
the
cp-add-contact-sensor
branch
from
October 17, 2022 11:36
e2e4fc2
to
59092ed
Compare
PR #23047: Size comparison from e6e8333 to 59092ed Increases (7 builds for bl602, bl702, cc13x2_26x2, esp32, telink)
Decreases (3 builds for cc13x2_26x2, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick commit c6025f / #22966 from master to v1.0-branch.