Added fix for WF200 certificate injection #23012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
|
PR #23012: Size comparison from b44263f to 54cf4de Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (4 builds for bl602, cc13x2_26x2, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 4, 2022
emargolis
approved these changes
Oct 4, 2022
woody-apple
approved these changes
Oct 4, 2022
|
@jmartinez-silabs - is this ok or should we place changes-requested on it? |
jmartinez-silabs
requested changes
Oct 5, 2022
jmartinez-silabs
approved these changes
Oct 20, 2022
auto-merge was automatically disabled
October 21, 2022 05:45
Head branch was pushed to by a user without write access
|
|
|
PR #23012: Size comparison from c8165be to e7d18f8 Increases (6 builds for bl702, psoc6, qpg, telink)
Decreases (3 builds for esp32, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Nov 2, 2022
…tion (project-chip#23012)" from silabs to silabs_1.0 Merge in WMN_TOOLS/matter from cherry-pick/WF200_bugfix_certificate_injection to silabs_1.0 Squashed commit of the following: commit 04b913c09bcead478551ffd90590de1ae3cd0c4b Author: shgutte <[email protected]> Date: Thu Oct 27 01:37:28 2022 +0530 Added fix for WF200 certificate injection (project-chip#23012) * Added fix for WF200 certificate injection * Adds changes according to comments * Adds changes according to comments * Add restyled changes according to comment Co-authored-by: riwaghe <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
rerasool
added a commit
to SiliconLabs/matter
that referenced
this pull request
Nov 2, 2022
…ficate injection (project-chip#23012)" from silabs to silabs_1.0 Merge in WMN_TOOLS/matter from cherry-pick/WF200_bugfix_certificate_injection to silabs_1.0 Squashed commit of the following: commit 04b913c09bcead478551ffd90590de1ae3cd0c4b Author: shgutte <[email protected]> Date: Thu Oct 27 01:37:28 2022 +0530 Added fix for WF200 certificate injection (project-chip#23012) * Added fix for WF200 certificate injection * Adds changes according to comments * Adds changes according to comments * Add restyled changes according to comment Co-authored-by: riwaghe <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Added fix for WF200 certificate injection * Adds changes according to comments * Adds changes according to comments * Add restyled changes according to comment Co-authored-by: riwaghe <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Added fix for WF200 certificate injection * Adds changes according to comments * Adds changes according to comments * Add restyled changes according to comment Co-authored-by: riwaghe <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Commissioning failed due to certificate injection due to the data type of attestation_credentials_base.
Change Overview:
Changed the data type of the attestation_credentials_base
Testing
Tested manually by using MG12+WF200