-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin] Update the build scripts to not override some user defined settings #23008
Merged
vivien-apple
merged 5 commits into
project-chip:master
from
vivien-apple:Darwin_UpdateChipXcodeConnectorToAllowMoreTargetTriple
Oct 6, 2022
Merged
[darwin] Update the build scripts to not override some user defined settings #23008
vivien-apple
merged 5 commits into
project-chip:master
from
vivien-apple:Darwin_UpdateChipXcodeConnectorToAllowMoreTargetTriple
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23008: Size comparison from b44263f to 31fa6fc Increases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, nrfconnect, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
0fafa71
to
6538834
Compare
PR #23008: Size comparison from b44263f to 6538834 Increases (5 builds for bl602, esp32, telink)
Decreases (3 builds for bl602, cc13x2_26x2, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 4, 2022
woody-apple
approved these changes
Oct 4, 2022
6538834
to
fef7975
Compare
PR #23008: Size comparison from 55b0a19 to fef7975 Increases (3 builds for bl602, bl702, telink)
Decreases (3 builds for bl602, k32w, telink)
Full report (17 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
fef7975
to
e4eb408
Compare
…from build/config/compiler/BUILD.gn
e4eb408
to
5846b70
Compare
PR #23008: Size comparison from 7455a55 to 5846b70 Increases (9 builds for bl702, esp32, psoc6, qpg, telink)
Decreases (2 builds for psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip_xcode_build_connector.sh
scripts when used for buildingios
is the one that defines thetarget
uses for building. That does not works fine with things such as Mac CatalystAdditionally, if one wants to build
darwin-framework-tool
with borings using./scripts/examples/gn_build_example.sh
the current setup complains since it is using//
and not${chip_root}
whileexamples/darwin-framework-tool
, like many other examples, does not have all the third_party repo as soft links directly into theirthird_party
folder which usually containsconnectedhomeip
.Lastly, when building
darwin-framework-tool
the SDKROOT setting is overriden.