Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the rendezvousInformation field of SetupPayload better. #23000

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Document the rendezvousInformation field of SetupPayload better. #23000

merged 1 commit into from
Oct 3, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Just adding documentation.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022 •
edited
Loading

PR #23000: Size comparison from 2060105 to c476f51

Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
platform target config section 2060105 c476f51 change % change
bl602 lighting-app bl602+rpc .text 1099772 1099776 4 0.0
bl702 lighting-app bl702 .debug_info 37902572 37902574 2 0.0
bl702+rpc .debug_info 41809182 41809184 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676547 676555 8 0.0
.text 586688 586696 8 0.0
esp32 all-clusters-app c3devkit (read only) 1223038 1223040 2 0.0
.flash.text 1223038 1223040 2 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803244 803248 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26826793 26826794 1 0.0
.debug_line 3670544 3670546 2 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26563575 26563577 2 0.0
.debug_line 3691260 3691262 2 0.0
light cy8ckit_062s2_43012 .debug_info 22027213 22027214 1 0.0
.debug_line 3261180 3261182 2 0.0
lock cy8ckit_062s2_43012 .debug_info 22265881 22265883 2 0.0
.debug_line 3259041 3259043 2 0.0
qpg lighting-app qpg6105+debug (read/write) 1148132 1148140 8 0.0
.text 595232 595240 8 0.0
telink ota-requestor-app tlsr9518adk80d (read/write) 818844 818852 8 0.0
text 577176 577180 4 0.0
Decreases (4 builds for cc13x2_26x2, nrfconnect, qpg)
platform target config section 2060105 c476f51 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174988 174980 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640803 640795 -8 -0.0
.text 561800 561792 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815352 815348 -4 -0.0
qpg lock-app qpg6105+debug (read/write) 1113204 1113196 -8 -0.0
.text 560300 560292 -8 -0.0
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2060105 c476f51 change % change
bl602 lighting-app bl602 (read/write) 1388818 1388818 0 0.0
.bss 90729 90729 0 0.0
.data 9928 9928 0 0.0
.text 1068424 1068424 0 0.0
bl602+rpc (read/write) 1434038 1434038 0 0.0
.bss 98161 98161 0 0.0
.data 10312 10312 0 0.0
.text 1099772 1099776 4 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188027 1188027 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67094 67094 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506897 1506897 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486444 486444 0 0.0
.debug_info 37902572 37902574 2 0.0
.debug_line 5255713 5255713 0 0.0
.debug_loc 3366185 3366185 0 0.0
.debug_ranges 359136 359136 0 0.0
.debug_str 3456572 3456572 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116536 116536 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564835 564835 0 0.0
.symtab 171584 171584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956624 956624 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283963 1283963 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75142 75142 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644442 1644442 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511820 511820 0 0.0
.debug_info 41809182 41809184 2 0.0
.debug_line 5630248 5630248 0 0.0
.debug_loc 3558817 3558817 0 0.0
.debug_ranges 381592 381592 0 0.0
.debug_str 3852472 3852472 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129928 129928 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624008 624008 0 0.0
.symtab 189392 189392 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030326 1030326 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676547 676555 8 0.0
(read/write) 174988 174980 -8 -0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89547 89547 0 0.0
.text 586688 586696 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640803 640795 -8 -0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78683 78683 0 0.0
.text 561800 561792 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 675239 675239 0 0.0
(read/write) 173448 173448 0 0.0
.bss 78468 78468 0 0.0
.data 3304 3304 0 0.0
.rodata 77071 77071 0 0.0
.text 597688 597688 0 0.0
lock-mtd LP_CC2652R7 (read only) 659099 659099 0 0.0
(read/write) 185276 185276 0 0.0
.bss 74156 74156 0 0.0
.data 3304 3304 0 0.0
.rodata 102939 102939 0 0.0
.text 555680 555680 0 0.0
pump-app LP_CC2652R7 (read only) 687403 687403 0 0.0
(read/write) 162004 162004 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90531 90531 0 0.0
.text 596388 596388 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671903 671903 0 0.0
(read/write) 177616 177616 0 0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86087 86087 0 0.0
.text 585336 585336 0 0.0
shell LP_CC2652R7 (read only) 667606 667606 0 0.0
(read/write) 186240 186240 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86262 86262 0 0.0
.text 581028 581028 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587578 587578 0 0.0
.app_xip_area 464204 464204 0 0.0
.bss 65792 65792 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591834 591834 0 0.0
.app_xip_area 463140 463140 0 0.0
.bss 71104 71104 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543346 543346 0 0.0
.app_xip_area 425028 425028 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110692 1110692 0 0.0
.bss 137708 137708 0 0.0
.data 2068 2068 0 0.0
.text 970892 970892 0 0.0
BRD4161A+rpc (read/write) 973636 973636 0 0.0
.bss 152236 152236 0 0.0
.data 2248 2248 0 0.0
.text 819132 819132 0 0.0
BRD4161A+rs911x (read/write) 1003840 1003840 0 0.0
.bss 170544 170544 0 0.0
.data 2060 2060 0 0.0
.text 831216 831216 0 0.0
lock-app BRD4161A+wf200 (read/write) 1147760 1147760 0 0.0
.bss 153424 153424 0 0.0
.data 2068 2068 0 0.0
.text 992244 992244 0 0.0
window-app BRD4161A (read/write) 1102684 1102684 0 0.0
.bss 139156 139156 0 0.0
.data 2092 2092 0 0.0
.text 961412 961412 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223038 1223040 2 0.0
(read/write) 1788118 1788118 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257688 257688 0 0.0
.flash.text 1223038 1223040 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233099 1233099 0 0.0
(read/write) 564004 564004 0 0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314736 314736 0 0.0
.flash.text 1227715 1227715 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 641472 641472 0 0.0
.bss 74816 74816 0 0.0
.data 2064 2064 0 0.0
.text 561864 561864 0 0.0
lock k32w0+release (read/write) 632768 632768 0 0.0
.bss 75592 75592 0 0.0
.data 2080 2080 0 0.0
.text 552368 552368 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2451792 2451792 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414436 1414436 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182911 1182911 0 0.0
bss 144433 144433 0 0.0
rodata 144208 144208 0 0.0
text 815352 815348 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161579 1161579 0 0.0
bss 143660 143660 0 0.0
rodata 135780 135780 0 0.0
text 803244 803248 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1744436 1744436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229446 1229446 0 0.0
.debug_aranges 111824 111824 0 0.0
.debug_frame 373372 373372 0 0.0
.debug_info 26826793 26826794 1 0.0
.debug_line 3670544 3670546 2 0.0
.debug_loc 3585489 3585489 0 0.0
.debug_ranges 338936 338936 0 0.0
.debug_str 3440244 3440244 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569480 569480 0 0.0
.symtab 421056 421056 0 0.0
.text 0 0 0 0.0
1544672 1544672 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1687044 1687044 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221245 1221245 0 0.0
.debug_aranges 111296 111296 0 0.0
.debug_frame 376452 376452 0 0.0
.debug_info 26563575 26563577 2 0.0
.debug_line 3691260 3691262 2 0.0
.debug_loc 3573126 3573126 0 0.0
.debug_ranges 337552 337552 0 0.0
.debug_str 3429257 3429257 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533569 533569 0 0.0
.symtab 407488 407488 0 0.0
.text 1488016 1488016 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1605572 1605572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055301 1055301 0 0.0
.debug_aranges 103504 103504 0 0.0
.debug_frame 346780 346780 0 0.0
.debug_info 22027213 22027214 1 0.0
.debug_line 3261180 3261182 2 0.0
.debug_loc 3271206 3271206 0 0.0
.debug_ranges 302880 302880 0 0.0
.debug_str 3234789 3234789 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469946 469946 0 0.0
.symtab 375936 375936 0 0.0
.text 1414736 1414736 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1639492 1639492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1057404 1057404 0 0.0
.debug_aranges 103904 103904 0 0.0
.debug_frame 348672 348672 0 0.0
.debug_info 22265881 22265883 2 0.0
.debug_line 3259041 3259043 2 0.0
.debug_loc 3299784 3299784 0 0.0
.debug_ranges 304824 304824 0 0.0
.debug_str 3254303 3254303 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472353 472353 0 0.0
.symtab 377600 377600 0 0.0
.text 1443640 1443640 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148132 1148140 8 0.0
.bss 110548 110548 0 0.0
.data 832 832 0 0.0
.text 595232 595240 8 0.0
lock-app qpg6105+debug (read/write) 1113204 1113196 -8 -0.0
.bss 106364 106364 0 0.0
.data 836 836 0 0.0
.text 560300 560292 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 788804 788804 0 0.0
bss 72472 72472 0 0.0
noinit 43520 43520 0 0.0
text 552774 552774 0 0.0
lighting-app tlsr9518adk80d (read/write) 810908 810908 0 0.0
bss 73320 73320 0 0.0
noinit 43520 43520 0 0.0
text 570994 570994 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 818844 818852 8 0.0
bss 74228 74228 0 0.0
noinit 43520 43520 0 0.0
text 577176 577180 4 0.0

@andy31415 andy31415 merged commit ed2b697 into project-chip:master Oct 3, 2022
@bzbarsky-apple bzbarsky-apple deleted the document-rendezvousInformation branch October 4, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track review - pending setup payload
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @mrjerryjohns @andy31415