-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In emberAfEndpointConfigure() change endpoint ID to a uint16_t #22998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new manual scripts * Added Auto generated File
* [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <[email protected]>
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
October 3, 2022 14:56
PR #22998: Size comparison from 5056270 to 2d17db0 Full report (2 builds for bl702)
|
jmartinez-silabs
approved these changes
Oct 3, 2022
jmartinez-silabs
approved these changes
Oct 3, 2022
PR #22998: Size comparison from 5056270 to 1672f76 Increases (15 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mrjerryjohns
reviewed
Oct 3, 2022
mrjerryjohns
approved these changes
Oct 3, 2022
jmartinez-silabs
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Oct 13, 2022
…o a uint16_t (project-chip#22998) Merge in WMN_TOOLS/matter from cherry_pick/unify_build_fix to silabs_1.0 Squashed commit of the following: commit 77f4fef74e58480c79bfb8dcfa67ffbdd57c61f3 Author: Sergei Lissianoi <[email protected]> Date: Mon Oct 3 16:51:28 2022 -0400 In emberAfEndpointConfigure() change endpoint ID to a uint16_t (project-chip#22998) * Test added march 8 (project-chip#15957) * Added new manual scripts * Added Auto generated File * [OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981) * Regen to fix CI failures (project-chip#15990) * [ota] Store Default OTA Providers in flash (project-chip#15970) * [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <[email protected]> * Remove merge artifacts * Cast boolean to uint8_t as setOnOffValue expects, fixes GCC 8.3 error * Make endpoint id a uint16_t as per spec * Restyled by clang-format * Update the signature of OnOffServer::setOnOffValue() to avoid casts * Fix printf argument and formatting Co-authored-by: kowsisoundhar12 <[email protected]> Co-authored-by: Carol Yang <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Damian Królik <[email protected]> Co-authored-by: Restyled.io <[email protected]>
nipatel-silabs
pushed a commit
to nipatel-silabs/connectedhomeip
that referenced
this pull request
Oct 19, 2022
…ndpoint ID to a uint16_t (project-chip#22998) Merge in WMN_TOOLS/matter from cherry_pick/unify_build_fix to silabs_1.0 Squashed commit of the following: commit 77f4fef74e58480c79bfb8dcfa67ffbdd57c61f3 Author: Sergei Lissianoi <[email protected]> Date: Mon Oct 3 16:51:28 2022 -0400 In emberAfEndpointConfigure() change endpoint ID to a uint16_t (project-chip#22998) * Test added march 8 (project-chip#15957) * Added new manual scripts * Added Auto generated File * [OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981) * Regen to fix CI failures (project-chip#15990) * [ota] Store Default OTA Providers in flash (project-chip#15970) * [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <[email protected]> * Remove merge artifacts * Cast boolean to uint8_t as setOnOffValue expects, fixes GCC 8.3 error * Make endpoint id a uint16_t as per spec * Restyled by clang-format * Update the signature of OnOffServer::setOnOffValue() to avoid casts * Fix printf argument and formatting Co-authored-by: kowsisoundhar12 <[email protected]> Co-authored-by: Carol Yang <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Damian Królik <[email protected]> Co-authored-by: Restyled.io <[email protected]>
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Nov 2, 2022
…o a uint16_t (project-chip#22998) Merge in WMN_TOOLS/matter from cherry_pick/unify_build_fix to silabs_1.0 Squashed commit of the following: commit 77f4fef74e58480c79bfb8dcfa67ffbdd57c61f3 Author: Sergei Lissianoi <[email protected]> Date: Mon Oct 3 16:51:28 2022 -0400 In emberAfEndpointConfigure() change endpoint ID to a uint16_t (project-chip#22998) * Test added march 8 (project-chip#15957) * Added new manual scripts * Added Auto generated File * [OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981) * Regen to fix CI failures (project-chip#15990) * [ota] Store Default OTA Providers in flash (project-chip#15970) * [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <[email protected]> * Remove merge artifacts * Cast boolean to uint8_t as setOnOffValue expects, fixes GCC 8.3 error * Make endpoint id a uint16_t as per spec * Restyled by clang-format * Update the signature of OnOffServer::setOnOffValue() to avoid casts * Fix printf argument and formatting Co-authored-by: kowsisoundhar12 <[email protected]> Co-authored-by: Carol Yang <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Damian Królik <[email protected]> Co-authored-by: Restyled.io <[email protected]>
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Nov 2, 2022
…o a uint16_t (project-chip#22998) Merge in WMN_TOOLS/matter from cherry_pick/unify_build_fix to silabs_1.0 Squashed commit of the following: commit 77f4fef74e58480c79bfb8dcfa67ffbdd57c61f3 Author: Sergei Lissianoi <[email protected]> Date: Mon Oct 3 16:51:28 2022 -0400 In emberAfEndpointConfigure() change endpoint ID to a uint16_t (project-chip#22998) * Test added march 8 (project-chip#15957) * Added new manual scripts * Added Auto generated File * [OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981) * Regen to fix CI failures (project-chip#15990) * [ota] Store Default OTA Providers in flash (project-chip#15970) * [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <[email protected]> * Remove merge artifacts * Cast boolean to uint8_t as setOnOffValue expects, fixes GCC 8.3 error * Make endpoint id a uint16_t as per spec * Restyled by clang-format * Update the signature of OnOffServer::setOnOffValue() to avoid casts * Fix printf argument and formatting Co-authored-by: kowsisoundhar12 <[email protected]> Co-authored-by: Carol Yang <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Damian Królik <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In emberAfEndpointConfigure() a uint8_t is used for the endpoint ID. According to the spec (7.18.2. Derived Data Types) a uint16_t must be used.
Separate minor issue: wrong type is being passed to OnOffServer::setOnOffValue()
Change overview
In emberAfEndpointConfigure() use uint16_t for the endpoint ID.
Change the type of the second parameter of OnOffServer::setOnOffValue() to chip::CommandId
Testing
Tested with Silabs Unify Matter bridge on Ubuntu