Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ensure that CHIPDeviceControllerFactory calls FabricTable::Sh… #22961

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

andy31415
Copy link
Contributor

…utdown (#22932)"

This reverts commit 57c7321.

Master shows that after this commit CHIP-repl tests are failing, seemingly with a segmentation fault. It is unclear why this is, likely we use some fabric objects after shutdown, however narrowing this down proved difficult.

Reverting for now to make CI green, will have to add this back with a fix once we figure out what is wrong.

@github-actions
Copy link

PR #22961: Size comparison from a6ecd62 to 4526891

Increases (4 builds for bl702, telink)
platform target config section a6ecd62 4526891 change % change
bl702 lighting-app bl702 (read/write) 1188027 1188043 16 0.0
.debug_info 37899859 37899860 1 0.0
.text 956624 956626 2 0.0
bl702+rpc .debug_info 41806469 41806470 1 0.0
.text 1030326 1030328 2 0.0
telink light-switch-app tlsr9518adk80d text 574624 574628 4 0.0
ota-requestor-app tlsr9518adk80d text 599026 599030 4 0.0
Decreases (1 build for linux)
platform target config section a6ecd62 4526891 change % change
linux chip-tool-ipv6only arm64 (read only) 10422588 10422300 -288 -0.0
.rodata 517404 517372 -32 -0.0
.text 8251204 8250948 -256 -0.0
Full report (12 builds for bl702, k32w, linux, mbed, nrfconnect, telink)
platform target config section a6ecd62 4526891 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188027 1188043 16 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67094 67094 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506903 1506903 0 0.0
.debug_aranges 133080 133080 0 0.0
.debug_frame 486388 486388 0 0.0
.debug_info 37899859 37899860 1 0.0
.debug_line 5252986 5252986 0 0.0
.debug_loc 3364624 3364624 0 0.0
.debug_ranges 359016 359016 0 0.0
.debug_str 3456120 3456120 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116536 116536 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564835 564835 0 0.0
.symtab 171584 171584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 956624 956626 2 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1283963 1283963 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75142 75142 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644448 1644448 0 0.0
.debug_aranges 140584 140584 0 0.0
.debug_frame 511764 511764 0 0.0
.debug_info 41806469 41806470 1 0.0
.debug_line 5627521 5627521 0 0.0
.debug_loc 3557369 3557369 0 0.0
.debug_ranges 381472 381472 0 0.0
.debug_str 3852020 3852020 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129928 129928 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624008 624008 0 0.0
.symtab 189392 189392 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030326 1030328 2 0.0
k32w light k32w0+release (read/write) 649972 649972 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574464 574464 0 0.0
lock k32w0+release (read/write) 706912 706912 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630948 630948 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10422588 10422300 -288 -0.0
(read/write) 706257 706257 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 517404 517372 -32 -0.0
.text 8251204 8250948 -256 -0.0
thermostat-no-ble arm64 (read only) 2387508 2387508 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143644 143644 0 0.0
.text 2001568 2001568 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455712 2455712 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418356 1418356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182911 1182911 0 0.0
bss 144433 144433 0 0.0
rodata 144208 144208 0 0.0
text 815352 815352 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161579 1161579 0 0.0
bss 143660 143660 0 0.0
rodata 135780 135780 0 0.0
text 803248 803248 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814548 814548 0 0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574624 574628 4 0.0
lighting-app tlsr9518adk80d (read/write) 836660 836660 0 0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592846 592846 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844612 844612 0 0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 599026 599030 4 0.0

@andy31415 andy31415 merged commit b60caa4 into project-chip:master Sep 29, 2022
sharad-patil24 pushed a commit to sharad-patil24/connectedhomeip that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants