-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Open basic commissioning window on pb0 press and release #22940
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:restart_comWindow
Sep 29, 2022
Merged
[Silabs] Open basic commissioning window on pb0 press and release #22940
jepenven-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:restart_comWindow
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
September 28, 2022 19:11
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
September 28, 2022 19:11
PR #22940: Size comparison from 46fd14a to dbbbc13 Decreases (2 builds for bl702)
Full report (8 builds for bl702, linux, mbed, telink)
|
andy31415
approved these changes
Sep 28, 2022
jepenven-silabs
approved these changes
Sep 29, 2022
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There was still some old code in silabs example applications to restart the BLE advertisement on a button press.
However, it didn't amount to much as the commission window was closed.
Changes:
On pb0 short press and release, Open the basic commissioning window. This will also start the BLE advertisement.
Tested manually with an EFR32 with lighting-app.
Wait for the initial advertisement/commissioning window to close. Press PB0, validated the BLE advertisement restarts and that the commissioning can be complete.