-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making xmls consistent with specs #22898
Making xmls consistent with specs #22898
Conversation
src/app/zap-templates/zcl/data-model/chip/general-commissioning-cluster.xml
Show resolved
Hide resolved
PR #22898: Size comparison from f2cd15f to 2ef87bb Increases (3 builds for cc13x2_26x2, efr32, esp32)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but you're going to have re-gen the code-generated bits, and consequently, you'll need to update the various cluster implementations, and then, update all the YAML tests, etc.
1490b87
to
9d9da1e
Compare
PR #22898: Size comparison from 57c7321 to 9d9da1e Increases (5 builds for bl602, bl702, cc13x2_26x2, telink)
Decreases (3 builds for cc13x2_26x2, nrfconnect, telink)
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
776c7e2
to
7f2a882
Compare
PR #22898: Size comparison from fa81768 to 7f2a882 Increases (5 builds for bl602, bl702, nrfconnect, psoc6)
Decreases (4 builds for psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22898: Size comparison from c6025f8 to a1fa36a Increases (4 builds for bl702, esp32, nrfconnect, telink)
Decreases (3 builds for efr32, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Problem
Change overview
Make attributes naming consistent with specs.
Testing
Verified attributes name with specs