-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker step to chef cloud build #22885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22885: Size comparison from c2e0f70 to 7c120e3 Increases (3 builds for bl602, bl702, telink)
Decreases (3 builds for bl602, nrfconnect, qpg)
Full report (16 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing and
franck-apple
September 27, 2022 17:42
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
turon,
woody-apple,
wbschiller,
vijs,
xylophone21 and
yunhanw-google
September 30, 2022 20:52
PR #22885: Size comparison from 0e012b1 to 25eab4c Increases (8 builds for bl602, bl702, cc13x2_26x2, nrfconnect, qpg, telink)
Decreases (4 builds for bl702, cc13x2_26x2, esp32, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 4, 2022
PR #22885: Size comparison from 69088be to 33c727a Increases (7 builds for bl602, bl702, cc13x2_26x2, qpg, telink)
Decreases (7 builds for bl702, cc13x2_26x2, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 4, 2022
@FernandoLGuzman Restyle CI is failing. |
PR #22885: Size comparison from 26dab6c to 143e13e Increases (1 build for bl702)
Decreases (1 build for bl702)
Full report (7 builds for bl702, linux, mbed, qpg)
|
PR #22885: Size comparison from ac19e88 to 23c4373 Increases (3 builds for esp32, psoc6)
Decreases (9 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview
Added an additional step at the end of the chef cloud build. This step will call a script to dockerize chef binaries and then push them to a GCR bucket.