-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QPG] Added Color Temperature action, Enhanced Hue attribute handling #22870
Merged
andy31415
merged 1 commit into
project-chip:master
from
tima-q:qpg/color_functionality_
Sep 28, 2022
Merged
[QPG] Added Color Temperature action, Enhanced Hue attribute handling #22870
andy31415
merged 1 commit into
project-chip:master
from
tima-q:qpg/color_functionality_
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tima-q
force-pushed
the
qpg/color_functionality_
branch
from
September 26, 2022 13:30
a131192
to
44ed0df
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
September 26, 2022 13:31
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
September 26, 2022 13:31
tima-q
force-pushed
the
qpg/color_functionality_
branch
from
September 26, 2022 14:02
44ed0df
to
71a3bc7
Compare
tima-q
changed the title
Added Color Temperature action, Enhanced Hue attribute
[QPG] Added Color Temperature action, Enhanced Hue attribute handling
Sep 26, 2022
PR #22870: Size comparison from 89fc821 to 71a3bc7 Increases above 0.2%:
Increases (1 build for qpg)
Decreases (5 builds for bl702, telink)
Full report (9 builds for bl702, linux, qpg, telink)
|
tima-q
force-pushed
the
qpg/color_functionality_
branch
from
September 26, 2022 15:47
71a3bc7
to
9182420
Compare
PR #22870: Size comparison from 1ddf6ad to 9182420 Increases above 0.2%:
Increases (3 builds for esp32, psoc6, qpg)
Decreases (10 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Sep 27, 2022
andy31415
approved these changes
Sep 28, 2022
tima-q
added a commit
to tima-q/connectedhomeip
that referenced
this pull request
Sep 28, 2022
…22870) Co-authored-by: Nikita Solianik <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Sep 28, 2022
Co-authored-by: Nikita Solianik <[email protected]> Co-authored-by: Nikita Solianik <[email protected]>
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…22870) Co-authored-by: Nikita Solianik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview