Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ameba] Fix Trailing Null #22836

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Sep 23, 2022

Issue Being Resolved

  • TC-BINFO-2.1 when reading location, it shows 3 chars. Remove trailing null after getPref_str_new

Change overview

  • src/platform/Ameba/AmebaConfig.cpp

* TC-BINFO-2.1 when reading location, it shows 3 chars. Remove trailing null after getPref_str_new
@github-actions
Copy link

PR #22836: Size comparison from edb93a0 to f7789d8

Decreases (1 build for bl702)
platform target config section edb93a0 f7789d8 change % change
bl702 lighting-app bl702+rpc .debug_info 41805210 41805209 -1 -0.0
.text 1030456 1030454 -2 -0.0
Full report (5 builds for bl702, linux, mbed)
platform target config section edb93a0 f7789d8 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188091 1188091 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67078 67078 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506921 1506921 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486408 486408 0 0.0
.debug_info 37898613 37898613 0 0.0
.debug_line 5252753 5252753 0 0.0
.debug_loc 3364043 3364043 0 0.0
.debug_ranges 359032 359032 0 0.0
.debug_str 3456012 3456012 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116472 116472 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564828 564828 0 0.0
.symtab 171600 171600 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 956754 956754 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284011 1284011 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75126 75126 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644466 1644466 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511784 511784 0 0.0
.debug_info 41805210 41805209 -1 -0.0
.debug_line 5627292 5627292 0 0.0
.debug_loc 3556747 3556747 0 0.0
.debug_ranges 381488 381488 0 0.0
.debug_str 3851912 3851912 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129864 129864 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624001 624001 0 0.0
.symtab 189408 189408 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030456 1030454 -2 -0.0
linux chip-tool-ipv6only arm64 (read only) 10381740 10381740 0 0.0
(read/write) 706257 706257 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 508332 508332 0 0.0
.text 8219428 8219428 0 0.0
thermostat-no-ble arm64 (read only) 2387508 2387508 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143676 143676 0 0.0
.text 2001536 2001536 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455680 2455680 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418324 1418324 0 0.0

@andy31415 andy31415 merged commit 5c6393a into project-chip:master Sep 23, 2022
@pankore pankore deleted the sve2_fix_trailing_null branch September 30, 2022 06:54
@pankore pankore restored the sve2_fix_trailing_null branch November 4, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants