-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable all the Darwin framework tests. #22781
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:enable-all-darwin-tests
Oct 3, 2022
Merged
Enable all the Darwin framework tests. #22781
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:enable-all-darwin-tests
Oct 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22781: Size comparison from 3aa138f to c9c0092 Increases (6 builds for bl602, bl702, telink)
Decreases (1 build for nrfconnect)
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
We had some tests disabled because multiple test files needed to commission a server, and after the first one ran the second one would fail. The fix is to put the server back into commissioning mode after a test is done.
bzbarsky-apple
force-pushed
the
enable-all-darwin-tests
branch
from
September 20, 2022 22:05
c9c0092
to
5e530b2
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov and
LuDuda
September 20, 2022 22:05
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
September 20, 2022 22:05
PR #22781: Size comparison from 3aa138f to 5e530b2 Increases (6 builds for bl602, bl702, psoc6, telink)
Decreases (4 builds for bl602, k32w, nrfconnect, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 3, 2022
msandstedt
approved these changes
Oct 3, 2022
PR #22781: Size comparison from 5056270 to e4543f7 Increases (2 builds for psoc6, telink)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (27 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some tests disabled because multiple test files needed to commission a server, and after the first one ran the second one would fail. The fix is to put the server back into commissioning mode after a test is done.
Fixes #22782