-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Moved GetSetupPasscode failure log. #22716
Merged
LuDuda
merged 1 commit into
project-chip:master
from
kkasperczyk-no:default_passcode_error_fix
Sep 25, 2022
Merged
[server] Moved GetSetupPasscode failure log. #22716
LuDuda
merged 1 commit into
project-chip:master
from
kkasperczyk-no:default_passcode_error_fix
Sep 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22716: Size comparison from 989ad8e to 2128cf5 Increases (6 builds for cc13x2_26x2)
Decreases (34 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 19, 2022
2128cf5
to
5d6e5bd
Compare
PR #22716: Size comparison from 3aa138f to 5d6e5bd Increases (6 builds for cc13x2_26x2)
Decreases (34 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 21, 2022
The GetSetupPasscode() failure log is printed even in case of using the default passcode, what may bring confusion to the user if everything went fine. Moved error log to be printed only if there is no default passcode to be used.
5d6e5bd
to
1dbe6e3
Compare
PR #22716: Size comparison from 7189344 to 1dbe6e3 Decreases (13 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
LuDuda
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
Moved error log to be printed only if there is no default passcode to be used.