Omit write-only attributes in wildcard processing #22686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This omits processing write-only attributes during wildcard processing of Reads/Subscribes. It only achieves this for attributes backed by the AttributeAccessInterface. Specifically, it watches for UnsupportedRead error being returned by AttributeAccessInterface::Read and if so, ignores the error specifically when handling a wildcard-based interaction. Added a Python test that validates that the new WriteOnlyInt8u attribute is not served when doing a wildcard read.
|
PR #22686: Size comparison from 9989fc1 to ba15fa8 Increases (45 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl702, cc13x2_26x2)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bauerschwan
approved these changes
Sep 16, 2022
tcarmelveilleux
approved these changes
Sep 16, 2022
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
lazarkov
pullapprove
bot
requested review from
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #22686: Size comparison from 9989fc1 to 593aa69 Increases (34 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl702, cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Marking 1.0: user reported issue, fix is very localized and this contains testing for the functionality. |
msandstedt
approved these changes
Sep 16, 2022
|
Merging even with test failure: this makes things better by passing Tests/Test Suites - Darwin The other darwin unit test failure needs to be investigated separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This omits processing write-only attributes during wildcard processing of Reads/Subscribes. It only achieves this for attributes backed by the AttributeAccessInterface. Specifically, it watches for UnsupportedRead error being returned by AttributeAccessInterface::Read and if so, ignores the error specifically when handling a wildcard-based interaction.
Added a Python test that validates that the new WriteOnlyInt8u attribute is not served when doing a wildcard read.
Issue Being Resolved
fixes #22564