-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin] Make sure the prefixes on the enum names match the type #22673
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Darwin_EnumPrefixMatchType
Sep 15, 2022
Merged
[darwin] Make sure the prefixes on the enum names match the type #22673
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Darwin_EnumPrefixMatchType
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
September 15, 2022 15:58
pullapprove
bot
requested review from
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
September 15, 2022 15:58
PR #22673: Size comparison from 822993c to 0929f5c Increases (1 build for nrfconnect)
Decreases (7 builds for bl602, bl702, nrfconnect, qpg, telink)
Full report (14 builds for bl602, bl702, linux, mbed, nrfconnect, qpg, telink)
|
vivien-apple
force-pushed
the
Darwin_EnumPrefixMatchType
branch
2 times, most recently
from
September 15, 2022 16:44
1f735d3
to
46469df
Compare
PR #22673: Size comparison from 7d707fa to 46469df Increases (3 builds for telink)
Decreases (1 build for bl702)
Full report (9 builds for bl702, linux, qpg, telink)
|
vivien-apple
force-pushed
the
Darwin_EnumPrefixMatchType
branch
from
September 15, 2022 17:10
46469df
to
71980fb
Compare
vivien-apple
force-pushed
the
Darwin_EnumPrefixMatchType
branch
from
September 15, 2022 17:21
71980fb
to
07ed811
Compare
PR #22673: Size comparison from 7d707fa to 07ed811 Increases (10 builds for bl602, cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, cc13x2_26x2, esp32, psoc6, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 15, 2022
woody-apple
approved these changes
Sep 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ject-chip#22673) * [darwin] Make sure the prefixes on the enum names match the type * Update generated code
bzbarsky-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 16, 2022
This is a re-landing of PR project-chip#22673 but with backwards-compat preserved. * Update generated code
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 17, 2022
) This is a re-landing of PR #22673 but with backwards-compat preserved. * Update generated code Co-authored-by: Vivien Nicolas <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ject-chip#23646) This is a re-landing of PR project-chip#22673 but with backwards-compat preserved. * Update generated code Co-authored-by: Vivien Nicolas <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ject-chip#23646) This is a re-landing of PR project-chip#22673 but with backwards-compat preserved. * Update generated code Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview