-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin] Add cluster and commands description from XML into MTRBaseClusters.zapt #22671
Closed
vivien-apple
wants to merge
3
commits into
project-chip:master
from
vivien-apple:Darwin_AddClusterCommandsDescriptionsFromXML_to_MTRBaseClusters
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
September 15, 2022 14:55
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 15, 2022 14:55
PR #22671: Size comparison from 822993c to 42570b2 Increases (6 builds for bl602, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, bl702, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Sep 15, 2022
PR #22671: Size comparison from 822993c to 0a23be4 Increases (20 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I have folded this PR into #22665 since it is doing a zap update which is necessary for this PR to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
This PR is exploring the part 1 of #22545
"In MTRBaseClusters.h, see if we can generate any sort of basic documentation for the interfaces and/or their methods."
The current output contains a lot of not-so informative description such as: "Command description for {{insert command name here}}" but some describe the effect of the command.
This PR relies on a ZAP change at: project-chip/zap#727
Change overview
MTRBaseClusters.h
file.