Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] fix the crash during CASE session resumption #22622

Merged
merged 1 commit into from
Sep 16, 2022
Merged

[nrfconnect] fix the crash during CASE session resumption #22622

merged 1 commit into from
Sep 16, 2022

Conversation

markaj-nordic
Copy link
Contributor

@markaj-nordic markaj-nordic commented Sep 14, 2022 •
edited
Loading

Issue Being Resolved

Change overview

Do not use DeviceProxy pointer in application callback (BindingHandler),
as this object instantiated as temporary object in the caller's code.

This is only application/platform related change.

@markaj-nordic
[nrfconnect] light-switch-app: fix the crash during CASE session resu…
f18bb61 
…mption.

Accessing DeviceProxy object in the application callback
is redundant and leads to crash, because of modified
lifetime of this object in Matter core.
@github-actions
Copy link

PR #22622: Size comparison from 8626d39 to f18bb61

Increases (1 build for bl702)
platform target config section 8626d39 f18bb61 change % change
bl702 lighting-app bl702 .debug_info 37894018 37894019 1 0.0
.text 957170 957172 2 0.0
Full report (7 builds for bl702, linux, mbed, qpg)
platform target config section 8626d39 f18bb61 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188427 1188427 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506731 1506731 0 0.0
.debug_aranges 133072 133072 0 0.0
.debug_frame 486348 486348 0 0.0
.debug_info 37894018 37894019 1 0.0
.debug_line 5253486 5253486 0 0.0
.debug_loc 3363590 3363590 0 0.0
.debug_ranges 360256 360256 0 0.0
.debug_str 3455308 3455308 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116504 116504 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957170 957172 2 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284339 1284339 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644310 1644310 0 0.0
.debug_aranges 140576 140576 0 0.0
.debug_frame 511724 511724 0 0.0
.debug_info 41800588 41800588 0 0.0
.debug_line 5628025 5628025 0 0.0
.debug_loc 3556258 3556258 0 0.0
.debug_ranges 382712 382712 0 0.0
.debug_str 3851275 3851275 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030872 1030872 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10345860 10345860 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503028 503028 0 0.0
.text 8188884 8188884 0 0.0
thermostat-no-ble arm64 (read only) 2368252 2368252 0 0.0
(read/write) 142497 142497 0 0.0
.bss 55233 55233 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 76704 76704 0 0.0
.dynamic 560 560 0 0.0
.got 5096 5096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141588 141588 0 0.0
.text 1987664 1987664 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455952 2455952 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418596 1418596 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130876 1130876 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577972 577972 0 0.0
lock-app qpg6105+debug (read/write) 1101888 1101888 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548988 548988 0 0.0

@andy31415 andy31415 merged commit d668dc2 into project-chip:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehampson tehampson tehampson left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] nrfconnect: crash happens during CASE resumption
5 participants
@markaj-nordic @andy31415 @tehampson @woody-apple @Damian-Nordic