-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align joiner functionality on ncs example with other platforms #2261
Merged
woody-apple
merged 3 commits into
project-chip:master
from
ktaborowski:Align-joiner-functionality-on-ncs-example-with-other-platforms
Aug 21, 2020
Merged
Align joiner functionality on ncs example with other platforms #2261
woody-apple
merged 3 commits into
project-chip:master
from
ktaborowski:Align-joiner-functionality-on-ncs-example-with-other-platforms
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktaborowski
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
August 20, 2020 12:53
ktaborowski
force-pushed
the
Align-joiner-functionality-on-ncs-example-with-other-platforms
branch
from
August 20, 2020 13:03
12c2809
to
f828a7c
Compare
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
saurabhst
approved these changes
Aug 20, 2020
andy31415
approved these changes
Aug 20, 2020
jelderton
approved these changes
Aug 21, 2020
woody-apple
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Example lock-app for the nrfconnect platform does not support Thread Joiner role.
Summary of Changes
Add a Thread Joiner to an example. The Joiner is activated by pressing button 3 on nRF52 DK board.
New behavior is described in README file.